Closed
Bug 1734711
Opened 3 years ago
Closed 3 years ago
Fix browser_test_mixed_content_download.js to work when download improvements are enabled
Categories
(Firefox :: Downloads Panel, task)
Tracking
()
RESOLVED
FIXED
95 Branch
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: Gijs, Assigned: sfoster)
References
Details
(Whiteboard: [fidefe-mr11-downloads])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This test fails because it expects the unknown content type dialog to appear. Instead, it should be possible to check for a download starting.
|
||
Updated•3 years ago
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
- Run the tests with both true and false values for the browser.download.improvements_to_download_panel pref
- Handle the case when the download improvements pref will cause the downloads to save by default and not prompt for how to handle it
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5fd6cb7efe4f
Fix the mixed-content tests to pass when download improvements are enabled. r=Gijs
Backout by mlaza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e31440a5130
Backed out changeset 5fd6cb7efe4f for causing bc failures on browser_test_mixed_content_download.js.
|
||
Comment 4•3 years ago
|
||
Backed out changeset 5fd6cb7efe4f (Bug 1734711) for causing bc failures on browser_test_mixed_content_download.js.
Backout link
Push with failures - bc2
Failure Log
Flags: needinfo?(sfoster)
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b24c23e09389
Fix the mixed-content tests to pass when download improvements are enabled. r=Gijs
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•