Closed Bug 1740492 Opened 3 years ago Closed 3 years ago

Cannot remove text range in a span with contenteditable="true" when text contains <br> tags

Categories

(Core :: DOM: Editor, defect, P2)

Product:
Core
Component:
DOM: Editor
Version:
Firefox 94
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox94 --- wontfix
firefox95 --- fixed
firefox96 --- fixed

People

(Reporter: guillermosimmross, Assigned: masayuki, NeedInfo)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

span_bug.html
(deleted), text/html
Details
Bug 1740492 - Add tests for the symptom (the bug has already been fixed by bug 1737540) r=m_kato!
(deleted), text/x-phabricator-request
Details
Attached file span_bug.html (deleted) —

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

Select a text range (using keyboard or mouse) that includes at least one of the <br> tags inside the span tag and press the delete key or Remove in the context remove of the selection.

Actual results:

Nothing happened.

Expected results:

The selected text should have been removed. This works on Firefox 92 and other browsers.

Component: Untriaged → DOM: Editor
Product: Firefox → Core

I can reproduce the issue in Nightly96.0a1 Windows10.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3db432e2820882f8a29b52e4a3a0baee9e8d19eb&tochange=7af78405aade4dbd64f4c713dc3feeed5d8ffa5b

Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox94: --- → affected
status-firefox95: --- → affected
status-firefox96: --- → affected
status-firefox-esr91: --- → unaffected
Ever confirmed: true
Keywords: regression
Regressed by: 1726064
Flags: needinfo?(masayuki)

I know only a few web apps uses inline editing host, but this symptom is serious for such web apps.

Assignee: nobody → masayuki
Severity: -- → S2
Status: NEW → ASSIGNED
Flags: needinfo?(masayuki)
OS: Unspecified → All
Priority: -- → P2
Hardware: Unspecified → All

Looks like that this is a dup of bug 1737540. I cannot reproduce this bug with the latest Nightly. Could you re-test this with the latest Nightly build?

Flags: needinfo?(guillermosimmross)

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #3)

Looks like that this is a dup of bug 1737540. I cannot reproduce this bug with the latest Nightly. Could you re-test this with the latest Nightly build?

Confirmed. It was fixed in Nightly96.0a1(20211110214946) Windows10.

status-firefox96: affected → fixed

Does the testcase from bug 1737540 cover this too or should we land a different one to cover this?

Flags: needinfo?(masayuki)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox95: affected → fixed
Depends on: 1737540
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)

Does the testcase from bug 1737540 cover this too or should we land a different one to cover this?

Not covered. I'll add WPT.

Flags: needinfo?(masayuki)
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/fccb09f46f3e Add tests for the symptom (the bug has already been fixed by bug 1737540) r=m_kato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31630 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: