Closed Bug 1742851 Opened 3 years ago Closed 3 years ago

Temporarily (?) increase timeout for automation valgrind run

Categories

(Developer Infrastructure :: General, enhancement)

x86_64
Linux
enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jseward, Assigned: shravanrn)

References

Details

Attachments

(1 file)

New RLBox-generated code hits a slow path in valgrind, relating to memory
address state changes associated with sandbox heap creation/destruction. This
only happens when valgrind is instructed to track the origins of undefined
values, which is a non-default setting requested by the automation run. See
valgrind_args in build/valgrind/mach_commands.py.

A proper fix requires investigation/fixing in valgrind. For now, we can
perhaps work around the automation run timeouts by increasing the timeout,
perhaps from 1800 (as now) to 2400. Removing --track-origins=yes would also
"fix" it immediately, but would cause a loss of useful information in any
undefined-value error messages reported by V.

Further ahead, we should upgrade valgrind to latest trunk (3.19.GIT) + fix for
this problem, if one can be found. That can be a separate bug though.

Blocks: 1741995
Assignee: nobody → shravanrn
Status: NEW → ASSIGNED
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c78d918c4111 Temporarily increase timeout for automation valgrind run r=bholley
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

The underlying bug, plus testcase, was filed upstream at
https://bugs.kde.org/show_bug.cgi?id=446103

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: