smoke testing 96 beta. fails attempting to post to alt.comp.software.thunderbird at news.aioe.org

GenericSendMessage FAILED: [Exception... "JavaScript component does not have a method named: "getMsgFolderFromURI"'JavaScript component does not have a method named: "getMsgFolderFromURI"' when calling method: [nsIMsgIncomingServer::getMsgFolderFromURI]" nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)" location: "JS frame :: resource:///modules/MimeMessageUtils.jsm :: getMsgFolderURIFromPrefs :: line 911" data: no] 2 MsgComposeCommands.js:5077
CompleteGenericSendMessage chrome://messenger/content/messengercompose/MsgComposeCommands.js:5077
AsyncFunctionThrow self-hosted:699

Also seeing

GenericSendMessage FAILED: [Exception... "JavaScript component does not have a method named: "getMsgFolderFromURI"'JavaScript component does not have a method named: "getMsgFolderFromURI"' when calling method: [nsIMsgIncomingServer::getMsgFolderFromURI]" nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)" location: "JS frame :: resource:///modules/MimeMessageUtils.jsm :: getMsgFolderURIFromPrefs :: line 911" data: no]

I tested with nntp.jsmodule false, and then again with nntp.jsmodule true and it works.

So either a restart after first having created the news account helped, or something (unrelated to news?) in that first startup was a contributing factor.

However, my drafts from the initial failed posting attempts are nowhere to be found. And saving a draft still fails with
GenericSendMessage FAILED: [Exception... "JavaScript component does not have a method named: "getMsgFolderFromURI"'JavaScript component does not have a method named: "getMsgFolderFromURI"' when calling method: [nsIMsgIncomingServer::getMsgFolderFromURI]" nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)" location: "JS frame :: resource:///modules/MimeMessageUtils.jsm :: getMsgFolderURIFromPrefs :: line 911" data: no]

For sake of simplicity I'm going to continue a mashup in this bug ...

after attempting to save a draft with ctrl+S, I tried closing the compose window with ctrl+W which fails to close, and the clicked "X" (in windows) and got ...

An error occurred executing the cmd_close command: [Exception... "JavaScript component does not have a method named: "getMsgFolderFromURI"'JavaScript component does not have a method named: "getMsgFolderFromURI"' when calling method: [nsIMsgIncomingServer::getMsgFolderFromURI]" nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)" location: "JS frame :: chrome://messenger/content/messengercompose/MsgComposeCommands.js :: ComposeCanClose :: line 6352" data: no] 4 globalOverlay.js:131
07:28:40.352
Uncaught
Exception { name: "NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED", message: "JavaScript component does not have a method named: "getMsgFolderFromURI"'JavaScript component does not have a method named: "getMsgFolderFromURI"' when calling method: [nsIMsgIncomingServer::getMsgFolderFromURI]", result: 2153185328, filename: "chrome://messenger/content/messengercompose/MsgComposeCommands.js", lineNumber: 6352, columnNumber: 0, data: null, stack: "ComposeCanClose@chrome://messenger/content/messengercompose/MsgComposeCommands.js:6352:26\n@chrome://messenger/content/messengercompose/MsgComposeCommands.js:250:8\n", location: XPCWrappedNative_NoHelper }

continuing with drafts attempts, using ctrl+S I get

NotAllowedError: Could not remove the file at C:\Users\wsm0\AppData\Local\Temp\nscopy-3.tmp

I see this yes.
MsgIncomingServer.jsm doesn't implement the mentioned method. But I don't know why it worked in the past.

This seems to work for me on Daily but not on 96, anyway implemented the missing interface.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/7f52c6e2de0d
Implement getMsgFolderFromURI in MsgIncomingServer.jsm to fix saving news draft. r=mkmelin

Any idea about the remaining problem(s)? Like I wrote on phab, the account was (apparently, by default) set to save sent on the nntp account which won't work. So Retry won't work either. However, the Save locally did also not work at that point which should work (but also create the Sent folder if not existing)

Yeah, it's a problem for accounts created by nntp-js before this patch. I don't have a solution except recreating the account or setting folders manually.

Will take a look at the retry/save to local process.

Thanks. We will want this on Monday's beta.

Comment on attachment 9254445 [details]
Bug 1744946 - Implement getMsgFolderFromURI in MsgIncomingServer.jsm to fix saving news draft. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1707550
User impact if declined: saving sent/draft doesn't for for news post
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment on attachment 9254445 [details]
Bug 1744946 - Implement getMsgFolderFromURI in MsgIncomingServer.jsm to fix saving news draft. r=mkmelin

[Triage Comment]
Approved for beta

Thunderbird 96.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/11c3120c488e

v.fixed in 96.0b2