Closed
Bug 1750753
Opened 3 years ago
Closed 3 years ago
Mispositioned select dropdowns in thunderbird.
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
98 Branch
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox96 | --- | unaffected |
firefox97 | --- | unaffected |
firefox98 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
This is because this returns null even though we're in a <browser>
.
Assignee | ||
Comment 1•3 years ago
|
||
And remove realFrameElement while at it, since it now should work for
those cases too. I audited callers in devtools/, toolkit/ and browser/
and they all should be ok with this change.
There are Thunderbird tests testing this, see the comments at the end of
the regressing bug.
I think this is better than doing a whack-a-mole changing frameElement
to window.browsingContext?.embedderElement, but lmk if you just want me
to fix the LayoutUtils.jsm caller instead.
Assignee | ||
Comment 2•3 years ago
|
||
Updated•3 years ago
|
Attachment #9259519 -
Attachment is obsolete: true
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b7de29bd274c
Use BrowsingContext.embedderElement rather than Window.frameElement in LayoutUtils. r=mconley
Comment 4•3 years ago
|
||
Backed out for causing mochitest chrome failures on test_focusrings.xhtml.
[task 2022-01-19T01:40:40.557Z] 01:40:40 INFO - TEST-PASS | dom/tests/mochitest/general/test_focusrings.xhtml | appearance on list after tab focus
[task 2022-01-19T01:40:40.558Z] 01:40:40 INFO - Buffered messages finished
[task 2022-01-19T01:40:40.559Z] 01:40:40 INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_focusrings.xhtml | mouse click on <button id='elem' class='canfocus'>Button</button> - got [object HTMLBodyElement], expected [object HTMLButtonElement]
[task 2022-01-19T01:40:40.559Z] 01:40:40 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:500:14
[task 2022-01-19T01:40:40.559Z] 01:40:40 INFO - testHTMLElements@chrome://mochitests/content/chrome/dom/tests/mochitest/general/test_focusrings.xhtml:171:7
[task 2022-01-19T01:40:40.559Z] 01:40:40 INFO - testMacFocusesFormControl@chrome://mochitests/content/chrome/dom/tests/mochitest/general/test_focusrings.xhtml:109:19
[task 2022-01-19T01:40:40.559Z] 01:40:40 INFO - pushPrefEnv@resource://specialpowers/SpecialPowersChild.jsm:899:13
[task 2022-01-19T01:40:40.559Z] 01:40:40 INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-01-19T01:40:40.560Z] 01:40:40 INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_focusrings.xhtml | mouse click on <button id='elem' class='canfocus'>Button</button> ring - got "0px", expected "2px"
[task 2022-01-19T01:40:40.561Z] 01:40:40 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:500:14
[task 2022-01-19T01:40:40.561Z] 01:40:40 INFO - testHTMLElements@chrome://mochitests/content/chrome/dom/tests/mochitest/general/test_focusrings.xhtml:172:7
[task 2022-01-19T01:40:40.561Z] 01:40:40 INFO - testMacFocusesFormControl@chrome://mochitests/content/chrome/dom/tests/mochitest/general/test_focusrings.xhtml:109:19
[task 2022-01-19T01:40:40.561Z] 01:40:40 INFO - pushPrefEnv@resource://specialpowers/SpecialPowersChild.jsm:899:13
[task 2022-01-19T01:40:40.561Z] 01:40:40 INFO - TEST-PASS | dom/tests/mochitest/general/test_focusrings.xhtml | mouse click on <button id='elem' class='canfocus'>Button</button> selector
Flags: needinfo?(emilio)
Updated•3 years ago
|
Keywords: regression
Updated•3 years ago
|
Has Regression Range: --- → yes
Assignee | ||
Updated•3 years ago
|
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f16516a913a0
Use BrowsingContext.embedderElement rather than Window.frameElement in LayoutUtils. r=mconley
Comment 6•3 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox98:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
Updated•3 years ago
|
status-firefox96:
--- → unaffected
status-firefox97:
--- → unaffected
status-firefox-esr91:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•