Move all simple selectors from reducers modules to selectors modules
Categories
(DevTools :: Debugger, task)
Tracking
(firefox98 fixed)
Tracking | Status | |
---|---|---|
firefox98 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(10 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details |
See bug 1750952.
This is about selector functions currently hosted in the reducers folder:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/reducers
This bug aims to bulk move all the trivial reducers, while keeping distinct bugs for the complex ones like sources, breakpoints, ...
Assignee | ||
Comment 1•3 years ago
|
||
Only this jest test was using it.
The react component is using this one instead:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/actions/sources/symbols.js#26-28
which depends on tabs reducer's framework attribute, which uses the ast's getSymbols selector:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/components/shared/SourceIcon.js#44
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/utils/tabs.js#35-38
Assignee | ||
Comment 2•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
I'm also sorting the import from index.js in order to help the maintenance of this list.
Assignee | ||
Comment 4•3 years ago
|
||
Assignee | ||
Comment 5•3 years ago
|
||
Assignee | ||
Comment 6•3 years ago
|
||
Assignee | ||
Comment 7•3 years ago
|
||
Assignee | ||
Comment 8•3 years ago
|
||
Assignee | ||
Comment 9•3 years ago
|
||
Assignee | ||
Comment 10•3 years ago
|
||
Comment 11•3 years ago
|
||
Comment 12•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1b3ac9c7faad
https://hg.mozilla.org/mozilla-central/rev/a1dbb1bbd840
https://hg.mozilla.org/mozilla-central/rev/d488d0622398
https://hg.mozilla.org/mozilla-central/rev/baee530c5d6a
https://hg.mozilla.org/mozilla-central/rev/c888273eef09
https://hg.mozilla.org/mozilla-central/rev/52aba77f897e
https://hg.mozilla.org/mozilla-central/rev/4ede7bf99a57
https://hg.mozilla.org/mozilla-central/rev/6588613b52df
https://hg.mozilla.org/mozilla-central/rev/4737adc165d0
https://hg.mozilla.org/mozilla-central/rev/1e42f62ff828
Description
•