wpt runner doesn't restore prefs set in .ini files
Categories
(Testing :: web-platform-tests, defect)
Tracking
(firefox99 fixed)
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: hiro, Assigned: jgraham)
References
(Depends on 1 open bug)
Details
Attachments
(3 files)
For wpt reftests, we explicitly set apz.allow_zooming to false. If a wpt reftest sets apz.allow_zooming to true, then subsequenst reftests run with the pref is true for some reasons.
Attaching file a patch to add two wpt reftests demonstrating this issue.
|
Assignee | |
Comment 1•3 years ago
|
||
Thanks, this testcase was useful. It seems like we're always clearing the pref value instead of restoring the previous value, because the pref reading function is incorrectly returning None for all pref values. I've got a patch, but need to run it through try since it will presumably affect some test results.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Previously we were always returning None from the pref getter, so we'd
only clear the pref value rather than restoring the previous value.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
Based on a testcase by hikezoe.birchill@mozilla.com
|
|
Assignee | |
Comment 4•3 years ago
|
||
https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=OsXIGo1zTKS2FTI6CR7-xQ.0&revision=8463feedeec3ea82f20a340b4d90e1af7a4074c2 is a try run here. Surprisingly I don't see many test status changes, but it does seem to pass the tests that hiro wrote.
|
||
Updated•3 years ago
|
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/737f6ccbbe11
https://hg.mozilla.org/mozilla-central/rev/5573d3d3f9e8
Description
•