Closed
Bug 1758107
Opened 3 years ago
Closed 3 years ago
Stop using ChromeUtils.import(..., null) for importing modules in dom/push
Categories
(Core :: DOM: Notifications, task)
Core
DOM: Notifications
Tracking
()
RESOLVED
FIXED
100 Branch
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(3 files)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
Bug 1758107 - Stop using ChromeUtils.import(..., null) for importing modules in dom/push/. r?dragana
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
There's a few instances remaining in dom/push/ where we're still passing null as the second argument.
I'm going to clean those up here.
|
Assignee | |
Comment 1•3 years ago
|
||
Also tidy up how imports are managed.
Depends on D140321
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D140322
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D140323
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6cdb5d20a02a
Stop using ChromeUtils.import(..., null) for importing modules in dom/push/test/xpcshell/head.js. r=mt
https://hg.mozilla.org/integration/autoland/rev/62a245d1fa5d
Stop using ChromeUtils.import(..., null) for importing modules in dom/push/. r=mt
https://hg.mozilla.org/integration/autoland/rev/e2acbe11b6a2
Fix some ESLint no-unused-vars warnings in dom/push/test. r=mt
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6cdb5d20a02a
https://hg.mozilla.org/mozilla-central/rev/62a245d1fa5d
https://hg.mozilla.org/mozilla-central/rev/e2acbe11b6a2
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•