Closed Bug 1762212 Opened 3 years ago Closed 3 years ago

Remove Resource API in favor of a JS Map in Sources reducer

Categories

(DevTools :: Debugger, task)

task

Tracking

(firefox101 fixed)

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

This is a slightly different split in how to tackle bug 1748222.
Instead of removing Resource API function one by one, here, I'm migrating the whole sources reducer+selector to a JS Map.

This makes the patch slightly bigger, but this is probably mandatory step toward migrating to a Map.

Blocks: 1748229

It looks like there is no major regression while migrating to a map:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=146f3014cdcf000eb05d889afdbe664943bfb1e0&originalSignature=3130994&newSignature=3130994&framework=12&originalRevision=5c95eebb4a5814f97bd991389557a5201859d0d6&page=1&showOnlyConfident=1
That, even if the current patch does copy the whole map on each modification/addition/removal!
We can probably followup and have a mutable map in the reducer.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7a205bdbd2e2 [devtools] Migrate sources reducer to a Map (instead of Resource API). r=bomsy
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
Blocks: 1772879
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: