Remove Resource API in favor of a JS Map in Sources reducer
Categories
(DevTools :: Debugger, task)
Tracking
(firefox101 fixed)
Tracking | Status | |
---|---|---|
firefox101 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
This is a slightly different split in how to tackle bug 1748222.
Instead of removing Resource API function one by one, here, I'm migrating the whole sources reducer+selector to a JS Map.
This makes the patch slightly bigger, but this is probably mandatory step toward migrating to a Map.
Assignee | ||
Comment 1•3 years ago
|
||
It looks like there is no major regression while migrating to a map:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=146f3014cdcf000eb05d889afdbe664943bfb1e0&originalSignature=3130994&newSignature=3130994&framework=12&originalRevision=5c95eebb4a5814f97bd991389557a5201859d0d6&page=1&showOnlyConfident=1
That, even if the current patch does copy the whole map on each modification/addition/removal!
We can probably followup and have a mutable map in the reducer.
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Updated•3 years ago
|
Comment 5•3 years ago
|
||
bugherder |
Description
•