Magnifier position is not ideal for multi line selection
Categories
(GeckoView :: General, defect, P2)
Tracking
(firefox99 unaffected, firefox100 unaffected, firefox101 wontfix, firefox102 wontfix, firefox110 fixed)
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | unaffected |
| firefox100 | --- | unaffected |
| firefox101 | --- | wontfix |
| firefox102 | --- | wontfix |
| firefox110 | --- | fixed |
People
(Reporter: emilio, Assigned: m_kato)
References
(Blocks 1 open bug)
Details
(Whiteboard: [geckoview:2022h2?])
Attachments
(2 files)
Screenshot_2022-04-17-06-52-26-30_984e1414ae90666a90f12ff17ec14a7f.jpg
The magnifier seems to be tied to the very top of the selection, which means that it's not easy to keep the selection line visible for something that isn't the last line, and even then it's very easy to go up accidentally, see screenshot.
Would it be sensible to add a little bit of spacing there?
|
Reporter | |
Comment 1•3 years ago
|
||
|
||
Comment 2•3 years ago
|
||
Makoto, is this bug a regression from your fix for magnifier bug 1639087?
|
Assignee | |
Comment 3•3 years ago
|
||
(In reply to Chris Peterson [:cpeterson] from comment #2)
Makoto, is this bug a regression from your fix for magnifier bug 1639087?
Hmm, I need something adjustment for magnifier position.... Looking...
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 4•2 years ago
|
||
Actually, current magnifier glass area is decided by current touch position.
To improve magnifier area, if we can get selection bounds, we use it instead of
touch position. And if selection is in <input> element, we can use vertical
center position of the element.
Since we don't expose Magnifier API, so we cannot add test for UI.
Also, this fix makes magnifier fission compatible.
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
|
|
||
Updated•2 years ago
|
Description
•