Closed Bug 1778229 Opened 2 years ago Closed 2 years ago

NNTP-JS implementation can't deal with "Article not found"

Categories

(MailNews Core :: Networking: NNTP, defect)

Thunderbird 102
defect

Tracking

(thunderbird_esr102 fixed, thunderbird103 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
thunderbird_esr102 --- fixed
thunderbird103 --- fixed

People

(Reporter: rachel, Assigned: rnons)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

de.comp.os.ms-windows.misc
Re: Windows-Lizenz/Intel-Aufkleber entfernen Tue 5 July 2022 2028 (GMT+2)

Loading the message hangs. The C++ implementation shows:
Article not found
The newsgroup server reports that it can't find the article.
Newsgroup server responded: No such article number 216939
Perhaps the article has expired?
Try searching for article: <1pumyxy.3vm2d85c2tecN@ID-7682.user.dfncis.de> (216939)

Flags: needinfo?(remotenonsense)
Assignee: nobody → remotenonsense
Status: NEW → ASSIGNED
Flags: needinfo?(remotenonsense)

Thanks, with the patch the said article now shows as "Article not found".

Regressed by: nntp-js
Target Milestone: --- → 104 Branch

Pushed by nicolai@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/e896d6f9826d
Show about:newserror for no article and other errors. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Regressions: 1778474

Comment on attachment 9284261 [details]
Bug 1778229 - Show about:newserror for no article and other errors. r=#thunderbird-reviewers

Request for this and bug 1778474, which fix the tests.
[Approval Request Comment]
Regression caused by (bug #): bug 1707550
User impact if declined: Expired message is shown as loading, but should show "no article" error
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9284261 - Flags: approval-comm-beta?

Comment on attachment 9284261 [details]
Bug 1778229 - Show about:newserror for no article and other errors. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9284261 - Flags: approval-comm-beta? → approval-comm-beta+
Regressions: 1779413

Comment on attachment 9284261 [details]
Bug 1778229 - Show about:newserror for no article and other errors. r=#thunderbird-reviewers

Request for this and bug 1778474, which fix the tests.
[Approval Request Comment]
Regression caused by (bug #): bug 1707550
User impact if declined: Expired message is shown as loading, but should show "no article" error
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Attachment #9284261 - Flags: approval-comm-esr102?

Comment on attachment 9284261 [details]
Bug 1778229 - Show about:newserror for no article and other errors. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Attachment #9284261 - Flags: approval-comm-esr102? → approval-comm-esr102+

Uplifting this bug to 102.1 caused all sorts of problems.

It looks like bug 1778474, bug 1745033, and bug 1779865 should also be uplifted to handle the situation.

Flags: needinfo?(vseerror)
Flags: needinfo?(remotenonsense)

Have you tried uplifting bug 1778474 as well? I did mention it in comment 7.

I think bug 1745033 and bug 1779865 are separate, I will uplift them after 104.

Flags: needinfo?(remotenonsense) → needinfo?(rob)

(In reply to Ping Chen (:rnons) from comment #11)

Have you tried uplifting bug 1778474 as well? I did mention it in comment 7.
Comments are easy to miss, best to request uplift on additional bugs.

Flags: needinfo?(rob)
Flags: needinfo?(vseerror)
Blocks: 1782365
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: