alert/confirm/prompt do not show in Web extension options pages
Categories
(Thunderbird :: Add-Ons: Extensions API, defect, P3)
Tracking
(thunderbird_esr102+ fixed, thunderbird107 affected)
People
(Reporter: tdulcet, Assigned: TbSync)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
wsmwk
:
approval-comm-esr102+
|
Details |
alert()
, confirm()
and prompt()
do not show in Thunderbird options pages. They work fine in Firefox.
I tested in the latest Thunderbird 91 ESR and 102/103 beta. Using mozregression, it looks like it was regressed by something related to bug 1646648. I get this error in the Error console:
NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIWindowWatcher.openWindow] PromptParent.jsm:161
Reporter | ||
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/8b330f7342ec
Check window type before using it as parent window in Services.ww.openWindow(). r=mkmelin
Assignee | ||
Comment 3•2 years ago
|
||
Comment on attachment 9300321 [details]
Bug 1780977 - Check window type before using it as parent window in Services.ww.openWindow(). r=mkmelin
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
alert/confirm/prompt do not show in Web extension options pages
Testing completed (on c-c, etc.):
On Daily for more than 20 days, on beta since merge day (14.11)
Risk to taking this patch (and alternatives if risky):
Low.
Comment 4•2 years ago
|
||
Comment on attachment 9300321 [details]
Bug 1780977 - Check window type before using it as parent window in Services.ww.openWindow(). r=mkmelin
[Triage Comment]
Approved for esr102
Comment 5•2 years ago
|
||
bugherder uplift |
Thunderbird 102.5.1:
https://hg.mozilla.org/releases/comm-esr102/rev/53bce6c0925c
Description
•