Closed Bug 1782825 Opened 2 years ago Closed 2 years ago

Intermittent browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js | single tracking bug

Categories

(Firefox :: Tabbed Browser, defect, P5)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
110 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox103 --- unaffected
firefox104 --- unaffected
firefox105 --- wontfix
firefox106 --- wontfix
firefox108 --- wontfix
firefox109 --- fixed
firefox110 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: florian)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [retriggered][stockwell unknown])

Attachments

(1 file)

Bug 1782825 - Force a GC at the end of browser_contentTheme_in_process_tab.js to make CSS animations stop, r=mconley.
(deleted), text/x-phabricator-request
Details

Filed by: mlaza [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=386185308&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/OCBaSeBpR3WL52kSU2rWlw/runs/0/artifacts/public/logs/live_backing.log

[task 2022-08-02T21:59:18.785Z] 21:59:18     INFO - TEST-PASS | browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js | The sidebar background text color should have been set by contentTheme.js - "rgba(0, 255, 0, 1)" == "rgba(0, 255, 0, 1)" - 
[task 2022-08-02T21:59:18.786Z] 21:59:18     INFO - Buffered messages logged at 21:59:11
[task 2022-08-02T21:59:18.786Z] 21:59:18     INFO - Leaving test bound test_in_process_tab
[task 2022-08-02T21:59:18.786Z] 21:59:18     INFO - Buffered messages finished
[task 2022-08-02T21:59:18.787Z] 21:59:18     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js | waiting for vsync to be disabled - timed out after 50 tries. - false == true - JS frame :: chrome://mochikit/content/browser-test.js :: ensureVsyncDisabled :: line 575
[task 2022-08-02T21:59:18.787Z] 21:59:18     INFO - Stack trace:
[task 2022-08-02T21:59:18.787Z] 21:59:18     INFO - chrome://mochikit/content/browser-test.js:ensureVsyncDisabled:575
[task 2022-08-02T21:59:18.787Z] 21:59:18     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-08-02T21:59:18.788Z] 21:59:18     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js | vsync remained enabled at the end of the test. Is there an animation still running? Consider talking to the performance team for tips to solve this. - false == true - JS frame :: chrome://mochikit/content/browser-test.js :: ensureVsyncDisabled :: line 576
[task 2022-08-02T21:59:18.788Z] 21:59:18     INFO - Stack trace:
[task 2022-08-02T21:59:18.788Z] 21:59:18     INFO - chrome://mochikit/content/browser-test.js:ensureVsyncDisabled:576
[task 2022-08-02T21:59:18.788Z] 21:59:18     INFO - GECKO(1311) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2022-08-02T21:59:18.788Z] 21:59:18     INFO - GECKO(1311) | MEMORY STAT | vsize 16123MB | residentFast 307MB | heapAllocated 122MB
[task 2022-08-02T21:59:18.789Z] 21:59:18     INFO - TEST-OK | browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js | took 8288ms

Set release status flags based on info from the regressing bug 1742842

status-firefox103: --- → unaffected
status-firefox104: --- → unaffected
status-firefox105: --- → affected
status-firefox-esr102: --- → unaffected
status-firefox-esr91: --- → unaffected

:florian, since you are the author of the regressor, bug 1742842, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(florian)
Depends on: 1781524

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #3)

:florian, since you are the author of the regressor, bug 1742842, could you take a look?
For more information, please visit auto_nag documentation.

There's discussion of the failure happening in bug 1781524.

Flags: needinfo?(florian)

Set release status flags based on info from the regressing bug 1742842

status-firefox106: --- → affected

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Tabbed Browser

Update:

There have been 37 failures within the last 7 days:

  • 23 failures on OS X 10.15 WebRender opt/debug
  • 8 failures on OS X 10.15 WebRender Shippable opt
  • 6 failures on OS X 11 WebRender Shippable opt

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=393302503&repo=autoland&lineNumber=1972

[task 2022-10-15T16:41:46.003Z] 16:41:46     INFO - TEST-PASS | browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js | The sidebar background text color should have been set by contentTheme.js - "rgba(0, 255, 0, 1)" == "rgba(0, 255, 0, 1)" - 
[task 2022-10-15T16:41:46.003Z] 16:41:46     INFO - Leaving test bound test_in_process_tab
[task 2022-10-15T16:41:46.004Z] 16:41:46     INFO - Buffered messages finished
[task 2022-10-15T16:41:46.004Z] 16:41:46     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js | waiting for vsync to be disabled - timed out after 50 tries. - false == true - JS frame :: chrome://mochikit/content/browser-test.js :: ensureVsyncDisabled :: line 592
[task 2022-10-15T16:41:46.004Z] 16:41:46     INFO - Stack trace:
[task 2022-10-15T16:41:46.004Z] 16:41:46     INFO - chrome://mochikit/content/browser-test.js:ensureVsyncDisabled:592
[task 2022-10-15T16:41:46.005Z] 16:41:46     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-10-15T16:41:46.006Z] 16:41:46     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js | vsync remained enabled at the end of the test. Is there an animation still running? Consider talking to the performance team for tips to solve this. - false == true - JS frame :: chrome://mochikit/content/browser-test.js :: ensureVsyncDisabled :: line 593
[task 2022-10-15T16:41:46.006Z] 16:41:46     INFO - Stack trace:
[task 2022-10-15T16:41:46.006Z] 16:41:46     INFO - chrome://mochikit/content/browser-test.js:ensureVsyncDisabled:593
[task 2022-10-15T16:41:46.006Z] 16:41:46     INFO - GECKO(1340) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2022-10-15T16:41:46.006Z] 16:41:46     INFO - GECKO(1340) | MEMORY STAT | vsize 16111MB | residentFast 314MB | heapAllocated 126MB
[task 2022-10-15T16:41:46.007Z] 16:41:46     INFO - TEST-OK | browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js | took 8385ms

Dao, as the owner of this component, can you assign the bug to someone?
Thank you.

Flags: needinfo?(dao+bmo)
Whiteboard: [retriggered] → [retriggered][stockwell needswork:owner]

Update:

There have been 34 failures within the last 7 days:

  • 26 failures on OS X 10.15 WebRender opt
  • 8 failures on OS X 10.15 WebRender Shippable opt

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=399927953&repo=autoland&lineNumber=1850

[task 2022-12-16T21:11:09.041Z] 21:11:09     INFO - TEST-PASS | browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js | The sidebar background text color should have been set by contentTheme.js - "rgba(0, 255, 0, 1)" == "rgba(0, 255, 0, 1)" - 
[task 2022-12-16T21:11:09.041Z] 21:11:09     INFO - Leaving test bound test_in_process_tab
[task 2022-12-16T21:11:09.041Z] 21:11:09     INFO - Buffered messages finished
[task 2022-12-16T21:11:09.042Z] 21:11:09     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js | waiting for vsync to be disabled - timed out after 50 tries. - false == true - JS frame :: chrome://mochikit/content/browser-test.js :: ensureVsyncDisabled :: line 587
[task 2022-12-16T21:11:09.042Z] 21:11:09     INFO - Stack trace:
[task 2022-12-16T21:11:09.042Z] 21:11:09     INFO - chrome://mochikit/content/browser-test.js:ensureVsyncDisabled:587
[task 2022-12-16T21:11:09.042Z] 21:11:09     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-12-16T21:11:09.042Z] 21:11:09     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js | vsync remained enabled at the end of the test. Is there an animation still running? Consider talking to the performance team for tips to solve this. - false == true - JS frame :: chrome://mochikit/content/browser-test.js :: ensureVsyncDisabled :: line 588
[task 2022-12-16T21:11:09.043Z] 21:11:09     INFO - Stack trace:
[task 2022-12-16T21:11:09.043Z] 21:11:09     INFO - chrome://mochikit/content/browser-test.js:ensureVsyncDisabled:588
[task 2022-12-16T21:11:09.043Z] 21:11:09     INFO - GECKO(1355) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2022-12-16T21:11:09.043Z] 21:11:09     INFO - GECKO(1355) | MEMORY STAT | vsize 16127MB | residentFast 321MB | heapAllocated 154MB
[task 2022-12-16T21:11:09.043Z] 21:11:09     INFO - TEST-OK | browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js | took 7757ms

I believe the root cause is bug 1803387.

Here is the profile I get with the test as currently in the tree when running this command: ./mach test browser/base/content/test/contentTheme/browser_contentTheme_in_process_tab.js --run-until-failure --profiler: https://share.firefox.dev/3V7cw0k
Notice how several screenshot tracks survive the end of the test, and end after a GCMajor

If I remove the existing workaround, the test fails at the first run: https://share.firefox.dev/3PB5Kyw

If I replace this workaround with Cu.forceGC();, the screenshot tracks no longer survive the end of the test: https://share.firefox.dev/3FEoPLJ

So I think we can silence the failures in this bug by adding a Cu.forceGC() call at the end of the test, but we really need to have a real fix for bug 1803387 at some point, or we will keep seeing similar failures on other tests.

Depends on: 1803387
Assignee: nobody → florian
Status: NEW → ASSIGNED
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6833706c10e2 Force a GC at the end of browser_contentTheme_in_process_tab.js to make CSS animations stop, r=mconley.

https://hg.mozilla.org/mozilla-central/rev/6833706c10e2

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox110: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
status-firefox108: --- → wontfix
status-firefox109: --- → affected
Flags: needinfo?(dao+bmo)

The patch landed in nightly and beta is affected.
:florian, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(florian)
Flags: needinfo?(florian)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: