Closed Bug 1783933 Opened 2 years ago Closed 2 years ago

Avoid sContentParents assertion

Categories

(Core :: DOM: Content Processes, task)

task

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(2 files)

As seen in bug 1745864, many kinds of leaks will cause us to not clean up ContentParents. This in turn means that sContentParents isn't empty when we shut down, which means we hit an assertion. This in effect causes leaks to get turned into a single generic assertion, which hurts distinguishing different leaks.

In bug 1661862, I wrote a little wrapper class that simply cleans up a static linked list when destroyed, rather than asserting. I'll do the same here.

This keeps us from asserting when a ContentParent leaks, in
order to keep different leaks from getting bucketed together
on TreeHerder.

This static variable used to be set in a method called RecvPrivateDocShellsExist,
but it is now always null.

Attachment #9289097 - Attachment description: Bug 1783933 - Avoid sContentParents assertion. → Bug 1783933, part 2 - Use StaticAutoPtr in ContentParent.
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/940d75dffee4 part 1 - Remove ContentParent::sPrivateContent. r=nika https://hg.mozilla.org/integration/autoland/rev/3b38f7a8b170 part 2 - Use StaticAutoPtr in ContentParent. r=nika
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: