Copy constructor of MultiTouchInput doesn't copy mLayersId
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: m_kato, Assigned: botond)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
+++ This bug was initially created as a clone of Bug #1783804 +++
From https://bugzilla.mozilla.org/show_bug.cgi?id=1783804#c9
(In reply to Hiroyuki Ikezoe (:hiro) from comment #5)
The
aInputis MultiTouchInput, in the copy constructor of the class we don't copy over mLayersId so that we loose the information there. I am not sure not copying over the value is intentional or not, below change should fix this issue. There are other places we need to properly copy over the layers id in widget/android/nsWindows.cpp for other types of events.
If that's not intentional then that seems like a footgun that we should fix. Maybe Botond knows?
From From https://bugzilla.mozilla.org/show_bug.cgi?id=1783804#c10
Yeah, totally agree. The mLayersId was introduced in bug 1524239, it looks to me it's unintentional. CCing Masayuki and Henri.
Failure to copy in the copy constructor is unintentional. Sorry about the bug.
|
Assignee | |
Comment 2•2 years ago
|
||
(In reply to Henri Sivonen (:hsivonen) from comment #1)
Failure to copy in the copy constructor is unintentional.
+1
|
|
Assignee | |
Comment 3•2 years ago
|
||
This ensures all fields of InputData are copied, including
new ones added in the future.
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Description
•