Closed
Bug 1789631
Opened 2 years ago
Closed 2 years ago
[Quickactions] NVDA screen reader doesn't read the help button properly
Categories
(Firefox :: Address Bar, defect)
Tracking
()
VERIFIED
FIXED
106 Branch
People
(Reporter: cbaica, Assigned: daisuke)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Found in
- Fx 106.0a1
Affected versions
- Fx 106.0a1
Affected platforms
- Windows 10
Steps to reproduce
- launch NVDA.
- Launch Firefox.
- Click the address bar.
- Using the keyboard, navigate to the quickactions help button.
Expected result
- NVDA reads 'help button' when the button is reached.
Actual result
- NVDA reads 'button'.
Regression range
- Not a regression.
Additional notes
- Please note that the button is not read out on mouse over like the rest of the quickaction buttons. This particular issues seems similar to the issue we have on intervention cards in bug 1625254.
|
Reporter | |
Updated•2 years ago
|
Has STR: --- → yes
|
Assignee | |
Comment 1•2 years ago
|
||
Hi Cristian, thank you very much!
To implement this, I’d like to hear your opinion as there are two options, I think.
- As the button has no tooltip on mouseover, set
titleattribute, and read out it. - Or, use
aria-labelto just read out.
And, as the help button fo quick suggest has tooltip, may we introduce it the same way?
What do you think? Dale, Drew?
Flags: needinfo?(dale)
Flags: needinfo?(adw)
|
|
Assignee | |
Comment 2•2 years ago
|
||
Sorry, I think that we should add tooltip not only reading out, I will add title attribute for it.
If you have any opinions, please let me know.
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Flags: needinfo?(dale)
Flags: needinfo?(adw)
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
||
Updated•2 years ago
|
Attachment #9294158 -
Attachment description: Bug 1789631: Add title and aria-label attribute to help button for QuickActions. → Bug 1789631: Add title attribute to help button for QuickActions.
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d14118fdc80
Add title attribute to help button for QuickActions. r=daleharvey,fluent-reviewers,flod
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
|
|
Reporter | |
Comment 6•2 years ago
|
||
The issue is verified fixed using the latest nightly Fx 107.0a1 on Windows 10. NVDA correctly reads out the attribute.
You need to log in
before you can comment on or make changes to this bug.
Description
•