Closed Bug 1792513 Opened 2 years ago Closed 2 years ago

QuickActions: Shrinked Buttons expand and wrap into a new line when activating a search engine

Categories

(Firefox :: Address Bar, defect)

defect

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox107 --- verified

People

(Reporter: mehmet.sahin, Assigned: daisuke)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached video Bildschirmvideo aufnehmen 2022-09-27 um 08.15.18.mov (obsolete) (deleted) —

Nightly 107.0a1 (2022-09-25) (64-Bit)
macOS

1.) Make the window smaller
2.) Focus the Address Bar
3.) Notice that the Quickaction buttons are shrinked to a smaller size without wrapping the line.
4.) Press the arrow down key on the keyboard until you reach a search engine, e.g. Amazon

Actual: Quickaction buttons expand and wrap into new lines

Expected: Quickaction buttons should stay as they are.

Not sure if this is intentional, but maybe you could have a look at this.

A screencast is attached.

Thanks :)

Blocks: 1782974
Attachment #9296298 - Attachment is obsolete: true
Flags: needinfo?(dharvey)

Not expected, the flex-wrap is set for when the user enters the Actions search mode otherwise they wouldnt be able to see all of the actions, typically this is when the user has clicked the actions search mode and the urlbar is otherwise empty. In this case (which I didn't realise) when the user scrolls through the one off actions buttons it enters the search mode. We need to do something smarter than the current #urlbar[searchmode] to only wrap when we fully enter the actions mode

Flags: needinfo?(dharvey)

Ah, I see. Thanks!

Assignee: nobody → daisuke
Status: NEW → ASSIGNED

The severity field is not set for this bug.
:adw, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(adw)
Attachment #9296430 - Attachment description: Bug 1792513: Show whole quick action buttons when a query for quickactions mode is started. → Bug 1792513: Do not show full list of Quick Actions while scrolling one off buttons.
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5c1df6520ce6 Do not show full list of Quick Actions while scrolling one off buttons. r=daleharvey,adw
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Flags: needinfo?(adw)

Verified as fixed using Firefox 107 beta 3 under Win 10 64-bit, Ubuntu 22.04 and Mac OSX 10.14; filled a small follow-up, bug 1796805.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: