Closed Bug 1793694 Opened 2 years ago Closed 2 years ago

Stop exposing `EditorUtils.h` and `HTMLEditUtils.h`

Categories

(Core :: DOM: Editor, enhancement, P3)

Product:
Core
Component:
DOM: Editor
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox107 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(7 files)

Bug 1793694 - part 1: Move some static inline methods of `HTMLEditor` to `HTMLEditUtils` r=m_kato!
(deleted), text/x-phabricator-request
Details
Bug 1793694 - part 2: Move some protected inline method definitions of `HTMLEditor` to non-exposed header r=m_kato!
(deleted), text/x-phabricator-request
Details
Bug 1793694 - part 3: Move definitions of `JoinNodesDirection` and `SplitNodeDirection` into a new exposed header file r=m_kato!
(deleted), text/x-phabricator-request
Details
Bug 1793694 - part 4: Stop exposing `HTMLEditUtils.h` r=m_kato!
(deleted), text/x-phabricator-request
Details
Bug 1793694 - part 5: Move `EditorUtils::MaskString` to `TextEditor` r=m_kato!
(deleted), text/x-phabricator-request
Details
Bug 1793694 - part 6: Stop exposting `EditorUtils.h` r=m_kato!
(deleted), text/x-phabricator-request
Details
Bug 1793694 - part 7: Stop exposting `CSSEditUtils.h` and `ChangeStyleTransaction.h` r=m_kato!
(deleted), text/x-phabricator-request
Details

They are designed for internal use in the editor module, but EditorBase.h and HTMLEditor.h depends on them, they are exposed for all. Now we can fix the dependence with some small fixes.

Severity: -- → N/A
Type: defect → enhancement
Priority: -- → P3
Assignee: nobody → masayuki
Status: NEW → ASSIGNED

They are used in public inline methods of HTMLEditor. Therefore, they should
be defined in an exposed header file without other internal use things for the
editor module. Then, we can stop exposing HTMLEditHelpers.h.

Depends on D158632

It's currently referred from outside only by TextServicesDocument.cpp.
It's not under libeditor but in the editor module. Therefore, let's allow
it to refer the header files under libeditor directly. Then, we can stop
exposing HTMLEditUtils.h.

Depends on D158633

It's the only method which is used outside of the editor module. Therefore,
we can stop exposing EditorUtils.h later.

Depends on D158634

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/14ad86b372a2 part 1: Move some static inline methods of `HTMLEditor` to `HTMLEditUtils` r=m_kato https://hg.mozilla.org/integration/autoland/rev/402a1ce83820 part 2: Move some protected inline method definitions of `HTMLEditor` to non-exposed header r=m_kato https://hg.mozilla.org/integration/autoland/rev/4840feba9c48 part 3: Move definitions of `JoinNodesDirection` and `SplitNodeDirection` into a new exposed header file r=m_kato https://hg.mozilla.org/integration/autoland/rev/71af69b71841 part 4: Stop exposing `HTMLEditUtils.h` r=m_kato https://hg.mozilla.org/integration/autoland/rev/534a55ac55a7 part 5: Move `EditorUtils::MaskString` to `TextEditor` r=m_kato https://hg.mozilla.org/integration/autoland/rev/a5c78fe9d7a3 part 6: Stop exposting `EditorUtils.h` r=m_kato https://hg.mozilla.org/integration/autoland/rev/f29238d734d4 part 7: Stop exposting `CSSEditUtils.h` and `ChangeStyleTransaction.h` r=m_kato
Regressions: 1795061
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: