Continual mozilla::gfx::DrawTargetWebgl::SharedContext::CreateShaders
Categories
(Core :: Graphics: Canvas2D, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: lsalzman)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
I see this while running https://storage.googleapis.com/tfjs-testing/segmentation-landscape/index.html on macOS.
|
Reporter | |
Updated•2 years ago
|
|
|
Reporter | |
Comment 1•2 years ago
|
||
Note: this was with gfx.canvas.accelerated.profile-frames=0
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
If we fail to compile DrawTargetWebgl's shaders, we bail out to a normal software canvas.
However, it will still try to create a DrawTargetWebgl every time we need to create a canvas.
To avoid this, remember if shader compilation failed in the process, and don't try to create
an accelerated canvas again in that case.
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 3•2 years ago
|
||
For canvas users that rapidly create and destroy canvases, we may end up creating
a new SharedContext (and hence ClientWebGLContext) if there are no more canvases
left between destruction and creation. To work around this, just keep alive the
SharedContext for the main thread (other threads are unfortunately a bit tricky
to support) so that canvas creation remains fast in this instance.
Depends on D158903
|
|
||
Updated•2 years ago
|
|
||
Comment 5•2 years ago
|
||
Backed out for causing mochitest failures in @ std::_Hashtable<unsigned int, std::pair<unsigned int const, RefPtr<mozilla::WebGLTextureJS>
Backout link: https://hg.mozilla.org/integration/autoland/rev/0db234071bf67f735564bbd0c2a37edaf84fb909
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 7•2 years ago
|
||
Backed out for causing multiple WebGL related failures
Push with failures - xpcshell // Failure log 1 - xpcshell // Failure log 2 - xpcshell
|
|
Assignee | |
Updated•2 years ago
|
|
|
||
Comment 9•2 years ago
|
||
Hello, this remote failure appeared on the full push as well a bit towards the end of the running tests, could you take a look at it as well? Thank you! Failure log here.
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 10•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9ee98b3301d0
https://hg.mozilla.org/mozilla-central/rev/5bc65958fa5c
|
||
Comment 11•2 years ago
|
||
Adding blocking to bug 1741501 as this bug improves the use of gpu-canvas (bug 1774972)
Description
•