from granrose: "I run "Run Junk Controls on selected messages" that it marks spams as junk, but it doesn't move them to my junk folder even though I have that pref set."

I wasn't aware that junkmail.js had included the lines for MOVING to be allowed yet ... But, I fully agree that "running junk mail controls" should apply ALL settings (Move, Priority Change, or whatever other features are incorporated into the Junk Mail UI)

*** Bug 188950 has been marked as a duplicate of this bug. ***

taking

>I fully agree that "running junk mail controls" should apply ALL settings I agree as well.

Mail triage team: nsbeta1+/adt2

related/equal to bug 194273?

I'm not so sure about this anymore. think about whitelisting and local folders (which don't have jmc controls).

If users specifically ask for JMCs to be run, I think they expect it to obey their settings. For Local (non acct) folders, we can either disable the menu item or identify only (since there is no pref to auto move them). If a Sender is in a user's AB, we still need to follow the settings the user has setup. If the user has "Msgs from people in my AB are not junk" enabled, we need to obey that. This shouldn't be any different than auto analyzing msgs on incoming mail.

right. you have to assume that if someone is running the JMC manually that they want to do that. For Local Folders people can do the manual JMC and move the marked messages by hand if they have to, or we just disable it since only msgs that people want to save get put into the Local Folders (right?).

see also bug #191042, which needs to be fix for manual running of jmc to be usable on imap.

I to test with a current build to see which preferences are being respected and which are not when running JMC on IMAP or POP Folders. I think it' already respecting the Address book preference, still checking all scenarios. It's not automatically moving the message after analyzing. Regarding Comment 8 paragraph 2, I just logged a bug 204517, for purge (which is one of the preferences) to work on a designated Junk in Local Folders so we need to be careful not to disable functionality for that.

Running junk mail controls does not respect the Address Book whitelist. splitting that out to a new bug so it can be fixed first. bug 204679

updated this bug to be specific to moving to junk folder after manually marking messages as junk or after running JMC on folder.

aiming for 1.4 final

re-use the existing code for this, in nsMsgDBView.cpp testing now, to see if it has a problem with moving / deleting messages that aren't selected.

hmm, this isn't the right approach. that will heed the "move / delete" on manual code. I think this has to work differently. re-working....

Comment on attachment 123856 [details] [diff] [review] new patch seeking review from david. it's similar in spirit to the fix for bug #194273, except that at the end, we select and move. and we only care about the "move on spam" pref, not the "move when manually marking as spam". (and there is no delete option.)

Comment on attachment 123856 [details] [diff] [review] new patch nit - combine these into one || if clause: + if (!spamSettings.level) + return; + // if the move functionality is turned off, bail out. + if (!spamSettings.moveOnSpam) + return;

Comment on attachment 123881 [details] [diff] [review] patch, with david's nit fixed this has r/sr=bienvenu I'll check with asa for a=.

Comment on attachment 123881 [details] [diff] [review] patch, with david's nit fixed a=sspitzer,asa (asa over aim earlier today)

fixed for 1.4 final.

Comment on attachment 123881 [details] [diff] [review] patch, with david's nit fixed a=asa (on behalf of drivers) for checkin to 1.4.

Using trunk build 20030523 on winxp, linux and macosx this is fixed. verified