Closed Bug 1801985 Opened 2 years ago Closed 2 years ago

Handle postbarriers in codegen for ObjectToIterator

Categories

(Core :: JavaScript Engine: JIT, task, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: iain, Assigned: iain)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sp3])

Attachments

(1 file)

Bug 1801985: Generate postbarrier in ObjectToIterator r=jandem!
(deleted), text/x-phabricator-request
Details

The initial implementation of ObjectToIterator used a separate MIR node for the post-barrier when setting objectBeingIterated. Jan pointed out in review that we can do better by handling the post-barrier in codegen: we don't need it in the VM call case, and we know that the iterator will always be tenured, so we can be more efficient.

Blocks: 1801189
No longer blocks: js-perf-experiments
Attachment #9313175 - Attachment description: Bug 1801985: Generate postbarrier in ObjectToIterator r=jandem → Bug 1801985: Generate postbarrier in ObjectToIterator r=jandem!
Pushed by iireland@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ae7b812fa58 Generate postbarrier in ObjectToIterator r=jandem

https://hg.mozilla.org/mozilla-central/rev/2ae7b812fa58

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Whiteboard: [sp3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: