Codepen demo (https://codepen.io/Mertl/pen/oNXmgmy?editors=0010 ) is slower than Chrome
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
People
(Reporter: mayankleoboy1, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/html
|
Details |
Go to : https://codepen.io/Mertl/full/oNXmgmy
https://share.firefox.dev/3iI8TAv
Faster, if possible.
|
Reporter | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
|
|
||
Comment 2•2 years ago
|
||
This profile doesn't look too unreasonable. There is quite a lot of time in/under str_includes, it would be nice to optimize this function with CacheIR similar to what we did for indexOf.
There's also some overhead from the recursion check in ToStringForStringFunction, I'll file a bug for that.
|
|
Reporter | |
Comment 3•2 years ago
|
||
Profile from latest Nightly: https://share.firefox.dev/3WZ5Xy5 . Visually, the patches didnt have much impact on the speed of the demo.
(ni :jandem to make sure they see the profile)
|
|
||
Updated•2 years ago
|
|
|
||
Comment 4•2 years ago
|
||
That makes sense; bug 1806608 was just a minor improvement.
This needs more work to optimize String.prototype.includes from JIT code. There may also be other opportunities in JIT code, but that will be easier to investigate when we have that integrated better with the profiler.
Description
•