Closed Bug 1815255 Opened 2 years ago Closed 2 years ago

Enable flexbox emulation everywhere (on nightly-only for now)

Categories

(Core :: XUL, task)

task

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Regressed 2 open bugs)

Details

Attachments

(2 files)

No description provided.

This only affects pages that don't enable it explicitly (so places
window, etc).

The main browser area and all in-content pages (plus a few other windows
etc) already enable it explicitly.

I took care of the issues I found, let's find the remaining issues, if
any, sooner rather than later.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8900b580582c Enable flexbox emulation on nightly. r=Gijs

Backed out for causing multiple mochitest failures

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/hyperlink/test_general.xhtml | wrong extra state bits for ['label@id="linkLabelWithValue" node', address: [object XULTextElement], role: link, name: 'Mozilla Foundation', address: [xpconnect wrapped (nsIAccessible, nsIAccessibleHyperLink)]]!got '0', expected 'horizontal'

Failure log 2: https://treeherder.mozilla.org/logviewer?job_id=404854431&repo=autoland

Reftest log: https://treeherder.mozilla.org/logviewer?job_id=404850682&repo=autoland

Flags: needinfo?(emilio)

Mostly changing XUL attributes to CSS properties.

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8c6426c60f9 Fix tests to deal with flexbox emulation. r=Jamie,Gijs https://hg.mozilla.org/integration/autoland/rev/983fe4e70647 Enable flexbox emulation on nightly. r=Gijs
Regressions: 1815771
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd09cf2a4abb Fix tests to deal with flexbox emulation. r=Jamie,Gijs https://hg.mozilla.org/integration/autoland/rev/b1173e8c7497 Enable flexbox emulation on nightly. r=Gijs

Backed out 2 changesets (Bug 1815255) for causing reftest failures.
Backout link
Push with failures <--> R5 <--> R2
Failure Log R5
Failure Log R2

Regressions: 1815820
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/772e1fb7bf58 Fix tests to deal with flexbox emulation. r=Jamie,Gijs https://hg.mozilla.org/integration/autoland/rev/62fd688e3359 Enable flexbox emulation on nightly. r=Gijs
Flags: needinfo?(emilio)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Regressions: 1816010
Regressions: 1816072
Regressions: 1816096
Regressions: 1816114
Regressions: 1816218
Regressions: 1816221
Regressions: 1816235
Regressions: 1816282
Regressions: 1816593
Regressions: 1816850
Regressions: 1818254
Regressions: 1818723
Regressions: 1819082
Regressions: 1819267
Regressions: 1819052
Regressions: 1819510
Regressions: 1821675
Regressions: 1825056
Regressions: 1828767
Regressions: 1829394
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: