Closed Bug 1815964 Opened 2 years ago Closed 2 years ago

Clean up VirtualDesktop mingw ifdefs

Categories

(Firefox :: Session Restore, enhancement)

Product:
Firefox
Component:
Session Restore
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1815964: Remove MinGW ifdefs in Virtual Desktop Manager r?#build,handyman
(deleted), text/x-phabricator-request
Details

We commented all of that out but we should remove those ifdefs when mingw supports it.

It's not clear to me why we define IVirtualDesktopManager when it's
available in headers. I do know that because we are defining it instead
of getting it from headers, we aren't defining the UUID of it in the
MinGW way (which of course is done in the MinGW headers) so if we
want to continue doing that, we will need to add that. Although
it would be better if we could remove it entirely and use the headers...

Depends on D169375

Assignee: nobody → tom
Status: NEW → ASSIGNED
Pushed by tritter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd3bf6187d86 Remove MinGW ifdefs in Virtual Desktop Manager r=firefox-build-system-reviewers,ahochheiden

https://hg.mozilla.org/mozilla-central/rev/bd3bf6187d86

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: