Closed Bug 1818329 Opened 2 years ago Closed 2 years ago

Allow negatives when parsing media feature values.

Categories

(Core :: CSS Parsing and Computation, task)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1818329 - Don't reject negative values at parse time in media features. r=dshin
(deleted), text/x-phabricator-request
Details
Bug 1818329 - Don't reject negative resolutions either. r=jfkthame
(deleted), text/x-phabricator-request
Details
No description provided.

Clean-up some other test expectations while at it.

No longer blocks: interop-2023
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa64d4d68a0c Don't reject negative values at parse time in media features. r=dshin
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/89c458212f3c Don't reject negative resolutions either. r=layout-reviewers,jfkthame
Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/beff44676d63 Backed out changeset 89c458212f3c for causing wpt reftest failures on image-set-invalid-resolution-rendering-2.html

https://hg.mozilla.org/mozilla-central/rev/fa64d4d68a0c

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c915de76eab3 Backed out changeset fa64d4d68a0c for causing wpt reftest failures on mq-negative-range-001.html. CLOSED TREE
Attachment #9319476 - Attachment description: Bug 1818329 - Don't reject negative resolutions either. r=#style,#layout → Bug 1818329 - Don't reject negative resolutions either. r=jfkthame
Flags: needinfo?(emilio)
Attachment #9319319 - Attachment description: Bug 1818329 - Don't reject negative values at parse time in media features. r=#layout,#style → Bug 1818329 - Don't reject negative values at parse time in media features. r=dshin
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8c7eb3fca5a8 Don't reject negative values at parse time in media features. r=dshin https://hg.mozilla.org/integration/autoland/rev/af4cdf10aafd Don't reject negative resolutions either. r=layout-reviewers,jfkthame
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38704 for changes under testing/web-platform/tests
Upstream PR was closed without merging
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6c3a6a328d47 Don't reject negative values at parse time in media features. r=dshin https://hg.mozilla.org/integration/autoland/rev/01c1a2d4f4fd Don't reject negative resolutions either. r=layout-reviewers,jfkthame

Backed out for causing wpt failures in image-set-parsing.html.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | /css/css-images/image-set/image-set-parsing.html | e.style['background-image'] = "image-set(url(example.png) 0x)" should not set the property value - assert_equals: expected "" but got "image-set(url("example.png") 0x)"
Flags: needinfo?(emilio)

How in the world did this try push not catch this? ;_; https://treeherder.mozilla.org/jobs?repo=try&revision=b2ccac0a2fea59626741aa8f181dcce8b13f2e9b

Flags: needinfo?(emilio)
Upstream PR was closed without merging
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d9f50896a6e9 Don't reject negative values at parse time in media features. r=dshin https://hg.mozilla.org/integration/autoland/rev/50b2f3e731ef Don't reject negative resolutions either. r=layout-reviewers,jfkthame

https://hg.mozilla.org/mozilla-central/rev/d9f50896a6e9
https://hg.mozilla.org/mozilla-central/rev/50b2f3e731ef

Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: