[imap-js] InternalError: too much recursion in ImapResponse.jsm:252
Categories
(MailNews Core :: Networking: IMAP, defect)
Tracking
(thunderbird_esr102 unaffected)
Tracking | Status | |
---|---|---|
thunderbird_esr102 | --- | unaffected |
People
(Reporter: mkmelin, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Maybe because of a large folder(???) I got
InternalError: too much recursion ImapResponse.jsm:252:24
which is let match = line.match(/[()\[\]" ]/);
https://searchfox.org/comm-central/rev/db81589f13e9d7b1d47c2a466d19b15715dcf277/mailnews/imap/src/ImapResponse.jsm#252
No steps to reproduce atm.
Reporter | ||
Comment 1•2 years ago
|
||
It's in a while loop so for some reason line must be getting the same value over and over again?
Comment 2•2 years ago
|
||
I am hitting that each and everytime I use Daily with the new JS code enabled.
STR are:
- Start Daily
- Look at JS Console
It will reproduce everytime.
I've asked for proper debugging steps on that matter on Matrix, but failed to get any reply.
Reporter | ||
Comment 3•2 years ago
|
||
The steps depends on if you're able to build or not.
For a reproducible case, I would had dump("line=" + line + "\n");
before the line I quoted in comment 0. Then check the native console for output when running it.
Reporter | ||
Comment 4•2 years ago
|
||
Make it more efficient by moving the regex outside of the loop and only doing search (not full match) for what we want.
Updated•2 years ago
|
Reporter | ||
Comment 5•2 years ago
|
||
I don't have a test case so let's hope this fixes it.
@gerard-majax: since you have it reproducible, please retest once it's in Daily.
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/d8a10226e8b3
[imap-js] Avoid "InternalError too much recursion" (for very large responses) in ImapResponse.jsm. r=rnons
Comment 7•2 years ago
|
||
I still see some with 20230301104821, is it what we expect?
Reporter | ||
Comment 8•2 years ago
|
||
No that one should have the fix. I'm out of clues atm.
Description
•