Description

There are three parts to this issue:

(A) When manually opening the Translations panel for an unsupported language, then opening the settings menu, the always-translate-language and never-translate-languages are correctly disabled, but their checkbox states are not updated and retain the previously displayed values.

(B) After visiting a site with an unsupported language and displaying the settings menu, returning to a site for which auto-translate is enabled but fails to translate will open up the wrong panel view.

(C) Visiting the settings menu in this view will display the wrong languages for the always-translate-language and never-translate-language menu items.

Steps to Reproduce

Note: See attached video for an example walkthrough of STR.

1. Download and install the latest Remote Settings Devtools XPI from the releases page on GitHub: https://github.com/mozilla-extensions/remote-settings-devtools/releases

2. Switch Remote Settings to a channel in which there is no Translations language model data, e.g. Local, to ensure that translations fail when invoked.

3. Navigate to a website for a currently supported language, e.g. https://es.wikipedia.org.

4. Open the settings menu in the Translations panel, and enable the checkbox for Always Translate for that language.

5. Navigate to a website for a not-yet-supported language, e.g. https://ko.wikipedia.org.

6. Manually open the Translations panel from the app menu.

7. Open the settings menu in the Translations panel.

(A) Expected Results

• [✔] The always-translate-language checkbox is disabled.
• [✔] The always-translate-language checkbox is not checked for this unsupported language.

(A) Actual Results

• [✔] The always-translate-language checkbox is disabled.
• [x] The always-translate-language checkbox is checked for this unsupported language.

Note: This defect occurs for, and should be fixed for, the never-translate-language checkbox as well. However, the subsequent steps are only triggered when always-translate-language is checked.

8. Navigate back to a site in the same supported language for which you previously enabled always-translate-language.

9. The Translations panel should open after failing to auto-translate.

(B) Expected Results

• [✔] The panel shows the default view with the failure to translate message in the current page's language.

(B) Actual Results

• [x] The panel shows the language no supported view for the unsupported language of the previous page.

10. Open the settings menu in the Translations panel.

(C) Expected Results

• [✔] The always-translate-language checkbox is enabled.
• [✔] The always-translate-language checkbox is checked.
• [✔] The always-translate-language checkbox displays the current, supported document language for this website.

(C) Actual Results

• [✔] The always-translate-language checkbox is enabled.
• [✔] The always-translate-language checkbox is checked.
• [x] The always-translate-language checkbox displays the previous, unsupported document language from the previous website.

Refactors the assertions for the always/never translate checkbox
menuitems in the translations panel settings menu.

The checks now verify the displayed language name as well as the
disabled state across all relevant translations tests.

Fixes an error where translations settings menu checkbox
states were not being updated correctly for pages
whose language is not supported by translations.

They were previously being disabled as intended,
but not unchecked.

Depends on D185483

Fixes a defect where the revisit view was not showing
properly when navigating to a website that triggers
auto-translate after previously viewing the panel
on a web page with an unsupported language.

Depends on D185484

Fixes a defect where the error view was not showing
properly when navigating to a website that triggers
auto-translate failure after previously viewing the panel
on a web page with an unsupported language.

Depends on D185485

https://hg.mozilla.org/mozilla-central/rev/c4879c4dae7f
https://hg.mozilla.org/mozilla-central/rev/ffe2a24e4df8
https://hg.mozilla.org/mozilla-central/rev/47402479636f
https://hg.mozilla.org/mozilla-central/rev/b6b4b1f3d301

Comment on attachment 9347490 [details]
Bug 1845611 - Refactor translations panel settings assertions r=gregtatum!

Beta/Release Uplift Approval Request

• User impact if declined:
  Some users will encounter this defect where the incorrect language is displayed in the Translations panel when following this specific sequence of events.
• Is this code covered by automated tests?:
  Yes
• Has the fix been verified in Nightly?:
  Yes
• Needs manual test from QE?:
  No
• If yes, steps to reproduce:
  I have personally verified the fix in Nightly using mozregression to pinpoint this exact patch.
  If anyone wishes to step through this again, the STR are the same as described in the bug.
• List of other uplifts needed:
  Bug 1847339
• Risk to taking this patch:
  Medium
• Why is the change risky/not risky? (and alternatives if risky):
  I consider this medium to low risk.
  This code makes changes to the translations panel UI. It is technically possible that this could have caused a regression in another edge-case of the panel UI code.
  However, I consider this fairly low risk, as it has not regressed any of our existing tests. New tests have been added for these cases, and I have not observed any regressed behaviors in manually testing within Nightly.
  It is also fairly early in the beta process, and there is plenty of time to observe these changes for regressions.
• String changes made/needed:
  None
• Is Android affected?:
  No

Comment on attachment 9347490 [details]
Bug 1845611 - Refactor translations panel settings assertions r=gregtatum!

Approved for 117.0b6