Closed Bug 1849332 Opened 1 year ago Closed 1 year ago

Fix remaining https-scheme failures in url/url-setters-stripping tests

Categories

(Core :: DOM: Networking, defect, P2)

Product:
Core
Component:
DOM: Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
118 Branch
Tracking Flags:
Tracking Status
firefox118 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1849332 - Ensure URL::SetPort rejects values with leading non-numeric junk. r=#necko-reviewers
(deleted), text/x-phabricator-request
Details

Bug 1818374 resolved most of the failures here, but there are a couple of remaining ones, as found in the url-setters-stripping.any.js.ini metadata file:

  [Setting port with leading U+0000 (https:)]
  [Setting port with leading U+001F (https:)]

It seems these are failing because URL::SetPort uses nsAString::ToInteger() to parse the port number, but this method skips over initial non-numeric (actually non-hexadecimal) characters in the string.

However, to be valid as a a value for the port setter, the string would need to begin with an ASCII digit, afaict:

https://url.spec.whatwg.org/#dom-url-port
https://url.spec.whatwg.org/#port-state

So we should check that before passing the string to ToInteger.

Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Blocks: interop-2023-url
Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged]
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00adce290a8f Ensure URL::SetPort rejects values with leading non-numeric junk. r=necko-reviewers,valentin

https://hg.mozilla.org/mozilla-central/rev/00adce290a8f

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox118: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: