Closed Bug 1910 Opened 26 years ago Closed 25 years ago

{inc} Box model vertical formatting problems

Categories

(Core :: Layout, defect, P3)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: braden, Assigned: buster)

References

()

Details

Though a previous build of NGLayout nailed this test, it now has a few problems: 1. The floated images are being painted over. 2. The top margin is nolonger present as it should be. (It looks like it is being added to the bottom margin.)
Status: NEW → ASSIGNED
The top-margin problem is a duplicate of 1583.
The painting problem is similar to bug 2007.
Setting all current Open/Normal to M4.
per leger, assigning QA contacts to all open bugs without QA contacts according to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Summary: Box model vertical formatting problems → Box model vertical formatting problems {incremental reflow}
I've checked in a 90% fix for this - the page now lays out correctly (you have to trigger a resize reflow to make it do the right thing). Incrementally, however, it does the wrong thing so I've retitled the bug.
Actually, the text (but not the background -- this is fixed now anyway) overlaying the image is correct behavior, since the floats have zero width since their width is not given.
Severity: normal → minor
Priority: P2 → P4
Summary: Box model vertical formatting problems {incremental reflow} → {inc} Box model vertical formatting problems
David: I disagree with you about the correct behavior of the text here. It should not overlay the images. From CSS2: "10.3.6 Floating, replaced elements If 'left', 'right', 'margin-left' or 'margin-right' are specified as 'auto', their computed value is '0'. If 'width' is 'auto', its value is the element's intrinsic width." Kipp: Mozilla still isn't behaving correctly as far as the top and bottom margins are concerned. This does not appear to be an incremental reflow problem. Should a new bug be filed on this?
You're right. I could have sworn I looked and the images were within a floated DIV, rather than floated themselves. I guess I didn't look. Hmmm.... I thought this was fixed so width was zero only for non-replaced content (counting tables as replaced, as they should be, since they have separate width rules). It must be going to zero even for replaced content. This seems to have regressed. The top margin still disappears on reflow, but the images now are overwritten again (was that ever fixed?).
I think the behavior of the top margin is correct. The top margin of #test should collapse with the margin of BODY through the zero margin, padding, and border of #testContainer and the zero padding of border of body. This means that the height of #testContainer doesn't start until the border top of #test. See the CSS2 errata: http://www.w3.org/Style/css2-updates/REC-CSS2-19980512-errata.html for section 10.6.3, and think about where the height of #testContainer is. You should put a padding on #testContainer to prevent the collapsing. NGLayout handles this correctly. However, the page still shows incremental reflow problems with the replaced element float widths.
*** Bug 8466 has been marked as a duplicate of this bug. ***
Severity: minor → normal
Priority: P4 → P3
Target Milestone: M15 → M11
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
The initial reflow and resize reflow now agree.
Status: RESOLVED → VERIFIED
Based on kipp's comments, marking as verified fixed with the Sept 16th build.
Based on kipp's comments, marking as verified fixed with the Sept 16th build.
You need to log in before you can comment on or make changes to this bug.