Closed
Bug 197583
Opened 22 years ago
Closed 22 years ago
nsHTMLDocument::GetMidasCommandManager has code to cache but doesn't
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
People
(Reporter: dbaron, Assigned: Brade)
Details
Attachments
(1 file)
|
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
nsHTMLDocument::GetMidasCommandManager looks like it caches its result, but it
doesn't. This is shown by the build warning:
/builds/trunk/mozilla/content/html/document/src/nsHTMLDocument.cpp: In member
function `nsresult
nsHTMLDocument::GetMidasCommandManager(nsICommandManager**)':
/builds/trunk/mozilla/content/html/document/src/nsHTMLDocument.cpp:4140:
warning: declaration
of `mMidasCommandManager' shadows a member of `this'
(Of course, thanks to bug 75621, I'm the only one who sees these warnings.)
The obvious fix is to remove "nsCOMPtr<nsICommandManager> " in the function
before "mMidasCommandManager".
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #117489 -
Flags: superreview?(dbaron)
Attachment #117489 -
Flags: review?(dbaron)
|
Reporter | |
Updated•22 years ago
|
Attachment #117489 -
Flags: superreview?(dbaron)
Attachment #117489 -
Flags: superreview+
Attachment #117489 -
Flags: review?(dbaron)
Attachment #117489 -
Flags: review+
|
|
Assignee | |
Comment 2•22 years ago
|
||
fix checked in; thx dbaron!
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•