Closed Bug 1988 Opened 26 years ago Closed 26 years ago

[PATCH] improvements to Open dialog file filtering

Categories

(Core Graveyard :: Viewer App, defect, P2)

x86
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: michael.j.lowe, Assigned: buster)

Details

Index: nsBrowserWindow.cpp =================================================================== RCS file: /cvsroot/mozilla/webshell/tests/viewer/nsBrowserWindow.cpp,v retrieving revision 3.121 diff -u -r3.121 nsBrowserWindow.cpp --- nsBrowserWindow.cpp 1998/12/18 05:38:59 3.121 +++ nsBrowserWindow.cpp 1998/12/19 13:53:29 @@ -508,15 +508,17 @@ { PRBool selectedFileName = PR_FALSE; nsIFileWidget *fileWidget; - nsString title("Open HTML"); + nsString title("Open"); nsresult rv = nsRepository::CreateInstance(kFileWidgetCID, nsnull, kIFileWidgetIID, (void**)&fileWidget); if (NS_OK == rv) { - nsString titles[] = {"all files","html" }; - nsString filters[] = {"*.*", "*.html"}; - fileWidget->SetFilterList(2, titles, filters); + nsString titles[] = {"All Readable Files", "HTML Files", + "XML Files", "Image Files", "All Files"}; + nsString filters[] = {"*.htm; *.html; *.xml; *.gif; *.jpg; *.jpeg; *.png", + "*.htm; *.html", "*.xml", "*.gif; *.jpg; *.jpeg; *.png", "*.*"}; + fileWidget->SetFilterList(5, titles, filters); fileWidget->Create(aParentWindow, title, eMode_load,
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
i applied your patch; look for it in a future build
QA Contact: 4078
Status: RESOLVED → VERIFIED
Keywords: patch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.