found using 2003.04.15 comm builds. i noticed that when caret browsing mode is on, the spacebar no longer scrolls down a page. also, the pageDown and pageUp keys don't seem to work either. 1. turn on caret browsing mode (hit F7). 2. go to http://mozilla.org 3. hit the spacebar to scroll downwards. results: nothing happens. it doesn't matter if you mouseclicked in the page before doing step 3, either. 4. mouseclick near the top of the page, to place the cursor to the left of the 1st paragraph of news under the "Mozilla News" section. 5. hit PageDown then PageUp. expected behavior: you should scroll downwards (a "page's" worth) then upwards in the document. actual behavior: on linux and win2k, i scroll barely a *line's* worth of content. on mac os x, no scrolling occurs at all.

Maybe regression from bug 201560?

I suspect myself because of all the scrolling work I've been doing, but ... 1)-3) seems to work OK in a few days old build, and I very much doubt my checkins this morning could have affected this. 4)-5), what happens is that the caret jumps down to the bottom of the page (on my system, it's at the start of a line reading "detailing the plans for"), and this happens to be just off the screen, so it scrolls up a line to show the caret. This would be normal behaviour for a text editor. Is it wrong for caret browsing, and if so, how?

i was looking at older builds (on linux) and the test for steps 1-3 appear to have regressed btwn the 2003.04.11.08 (spacebar scrolls) and 2003.04.14.08 (spacebar doesn't scroll) builds. should i spin off a separate bug for steps 4-5? that seems to have been a problem since the beginning of this month. i'll check older builds to see if it's actually a regression.

hrm, steps 4-5 might be an existing bug --if i go as far back as a build from january, i still encounter problems with using pageDown and pageUp to scroll. the behavior differs btwn older and recent builds, so there might be a regression added there as well. anyhow, here's the test case --for clarity i'll now refer to steps 1-3 above as "case (a)" and the pageDown/Up test as "case (b)". case b ------ 0. caret browsing mode ON. 1. go to http://mozilla.org/ 2. click near the 1st paragraph, eg, just to the left of the sentence "4th Annual Mozilla Party..." 3. hit PageDown till you reach the bottom of the page --which works on older builds; i hit PageDn 4x. 4. hit PageUp till you reach the top of the page (again 4x on older builds). 5. repeat step 3 (hitting PageDn again). results: in older builds, scrolling downwards stops after the 2nd time i hit PageDn. an "older build" in this case would be a build from 2003.03.20 or earlier. builds after then seem to fail at either step 3 or 4 (alas, don't see a consistent pattern yet after 3/20).

forgot to mention earlier, but would case (b) somehow be caused by something similar to bug 140644?

i encounter the bug in case (a) when opening a link in a new window or a new tab --spacebar no longer scrolls the resulting page.

Adding user_pref("accessibility.browsewithcaret", true); to user.js in Camino results in identical behavior there too. Once added, neither the space bar nor the page up/down keys can be used to scroll at all.

adt: nsbeta1+/adt3

I have the same problem (or a variant) with Moz1.4b on OSX(10.2.6). Spacebar, pageup and pagedown have gone away completely. No caret mode in sight.

I find that pageup/pagedown are working with caret browsing for me, but not space.

> ------- Additional Comment #1 From Simon Fraser 2003-04-15 12:53 ------- > Maybe regression from bug 201560? Yep, that's what caused it. The space is defined in htmlBindings.xml as cmd_scroll PageDown instead of cmd_movePageDown. In the past this would move the caret if caret mode was turned on. However, I'm not sure why it's not at least scrolling the page. Sarah, are the pageup/pagedown keys only regressed on mac? -> Sfraser, or was bug 201560 Brade's code?

some testing with 2003.05.14 builds. case a: using spacebar with caret mode ON in browser. tested at http://mozilla.org ------ results: on all 3 platforms, the spacebar fails to scroll downwards. case b1: using pageUp and pageDown with caret mode ON in browser. ------- results vary by platform: * Mac fails to scroll at all. * Win2k and Linux: i can hit PageDn to reach the bottom of the page, then PageUp to reach the top. if i want to go down again (PageDn), i get stuck part way. on win2k (but using shift-right arrow), the caret is stuck at the beginning of the "Search" text. on linux, the caret is stuck at the end of the "Search" text. case b2: using pageUp and pageDown in composer, editing http://mozilla.org ------- results vary by platform: Mac: no scrolling issues in composer. Win2k and Linux: as in (b1), the caret eventually gets stuck in the same location when using PageDown and PageUp keys. questions: are there three separate issues here? * spacebar not working at all in caret mode (browser). * Mac failing to scroll w/pageDown or pageUp in caret mode (browser). * Win2k and Linux eventually getting stuck when using pageDown / pageUp.

okay, spun off bugs: * this one covers spacebar failing on all platforms, caret mode ON * bug 205845: Mac fails to scroll with pageDown or pageUp in caret mode * bug 205846: caret eventually gets stuck when trying to scroll with PageDown / PageUp keys

narrower regression window for this bug, using linux comm builds: works with 2003.04.11.08 broken with 2003.04.11.22

Near as I can tell, caret mode isn't documented =anywhere= in the browser package. What is it? Why isn't there an obvious graphic cue that the browser is in a different mode?

*** Bug 130779 has been marked as a duplicate of this bug. ***

I am working with an installation of 1.5. I am no longer able to navigate with the space bar. Earlier the spacebar used to enable page-down scrolling for me. The pagedown key still works, but the space bar doesn't. I have noticed this behavior after installing NOScript and FasterFox extensions. Help. Mr Tired

(In reply to comment #13) > > * this one covers spacebar failing on all platforms, caret mode ON I'm changing the summary of this bug to refer to this problem only.

Handle cmd_ScrollPageUp/Down in caret browsing mode. This fixes bug 205845 as well.

Comment on attachment 233647 [details] [diff] [review] patch Seems reasonable....

Checked in: Checking in dom/src/base/nsGlobalWindowCommands.cpp; /cvsroot/mozilla/dom/src/base/nsGlobalWindowCommands.cpp,v <-- nsGlobalWindowCommands.cpp new revision: 1.19; previous revision: 1.18 done

Comment on attachment 233647 [details] [diff] [review] patch There's very little risk in taking this on the branch, IMO.

Comment on attachment 233647 [details] [diff] [review] patch a=mconnor on behalf of drivers for 1.8 branch checkin

Checked in to 1.8 branch: Checking in mozilla/dom/src/base/nsGlobalWindowCommands.cpp; /cvsroot/mozilla/dom/src/base/nsGlobalWindowCommands.cpp,v <-- nsGlobalWindowCommands.cpp new revision: 1.17.6.1; previous revision: 1.17 done