User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030429 Mozilla Firebird/0.6 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030429 Mozilla Firebird/0.6 In Options-Privacy, the description for the download manager history is crap. Reproducible: Always Steps to Reproduce: 1. Menu Tools - Options 2. Select Privacy 3. Click the (+) besides Download Manger History Actual Results: In Options-Privacy, the description for the download manager history reads as follows: The Downlaod Manager keeps track of recently downloaded files. XXXben - blake, we need at the very least a toggle here, probably a retention window as well Expected Results: The sentence starting with "XXXben" should not be displayed. I suggest not to make notes like this in the UI.

Yeah, you're right, that shouldn't be there and a milestone should not be released with that kind of thing present. -->Confirming -->Reassigning to Ben -->Setting Milestone to 0.6 -->Blocks bug 191524

Someone with permissions needs to review and check-in this fix as I do not have permission to do so. I also created Bug 205276 to allow the developers to decide whether the functionality described in the comment should be implemented.

Comment on attachment 122974 [details] [diff] [review] Patch to remove 'XXXben....' comment in download manager history prefs window Requesting patch review by Ben Goodger.

Ben, please have a look at comment 4.

This should really make it into 0.6. We've already got the patch. And it couldn't be more simple.

This already shipped in 0.6. Addding "polish" keyword, as this is a _very_ rough edge! The change itself looks fine, but I can't review (not enough experience w/patches and all). CC'ing some people (taken from Firebird reviewers/UI folks/my own random memories) Someone please review this one-liner for a fix that makes us look dumb.

I'm not yanking the string until the feature is in. We've released now, it's fine, it's a pre-1.0 pre-final beta-type release. This sort of thing is not uncommon in commercial software. If we removed it it'd have to go back in after a release anyway as a reminder to do the feature, additional work I don't want to have to do.

Well Ben, if everyone used the UI as a TODO-list it would look a bit ugly;-) Seriously, isn't a bug in bugzilla enough as a reminder? (bug 205276)

this one in its current state is WONTFIX. duping against 205276 as that is the real bug, not this. those interested can move their votes over, but it'll get handled before 0.7 *** This bug has been marked as a duplicate of 205276 ***

taking QA contact, sorry about the bugspam

Mass-verifying. Sorry for bugspam.

Comment on attachment 122974 [details] [diff] [review] Patch to remove 'XXXben....' comment in download manager history prefs window Removing review request

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change