Closed Bug 205861 Opened 22 years ago Closed 20 years ago

comma are permitted in queriable sort values

Categories

(Bugzilla :: Administration, task)

task
Not set
major

Tracking

()

RESOLVED DUPLICATE of bug 67036

People

(Reporter: mcoulson, Assigned: justdave)

References

Details

User-Agent: Mozilla/5.0 Galeon/1.2.5 (X11; Linux i686; U;) Gecko/0 Build Identifier: Mozilla/5.0 Galeon/1.2.5 (X11; Linux i686; U;) Gecko/0 For example you create a Target Milestone with the value of "Dec 31, 2003" when you run a query with the value "Dec 31, 2003" as target milestone value it will split the "Dec 31, 2003" into "Dec 31" and "2003" due to the fact that we use the comma as a delimiter in our split. Making it so that we can handle comma's in these values would make the query code pretty ugly most likely so it would probably be better to not permit the use of comma's in queriable fields like target milestone so that we don't run into these problems. I am using Bugzilla 2.16 and as a result of this bug any queries that we use with target milestones (since they all have dates with commas) results in inconsistant results. Turning on debug for bug_list.cgi results in this SQL statement SELECT DISTINCT bugs.bug_id, bugs.groupset, bugs.bug_severity, bugs.priority, bugs.rep_platform, map_assigned_to.login_name, bugs.bug_status, bugs.resolution, bugs.short_desc FROM bugs, profiles map_assigned_to, profiles map_reporter LEFT JOIN profiles map_qa_contact ON bugs.qa_contact = map_qa_contact.userid LEFT JOIN cc selectVisible_cc ON bugs.bug_id = selectVisible_cc.bug_id AND selectVisible_cc.who = 1 WHERE ((bugs.groupset & 32778367) = bugs.groupset OR (bugs.reporter_accessible = 1 AND bugs.reporter = 1) OR (bugs.cclist_accessible = 1 AND selectVisible_cc.who = 1 AND not isnull(selectVisible_cc.who)) OR (bugs.assigned_to = 1) OR (bugs.qa_contact = 1)) AND bugs.assigned_to = map_assigned_to.userid AND bugs.reporter = map_reporter.userid AND (bugs.target_milestone = '---' OR bugs.target_milestone = 'April 14' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'April 21' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'April 28' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'April 30' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'April 7' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'Dec 31' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'December 12' OR bugs.target_milestone = ' 2002' OR bugs.target_milestone = 'February 14' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'February 21' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'February 24' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'February 7' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'January 31' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'March 10' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'March 17' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'March 3' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'March 31' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'May 5' OR bugs.target_milestone = ' 2003' OR bugs.target_milestone = 'Release 0.0.8') AND (bugs.version = '0.0.1' OR bugs.version = '0.0.2' OR bugs.version = '0.0.3' OR bugs.version = '0.0.4' OR bugs.version = '0.0.5' OR bugs.version = '0.0.6' OR bugs.version = '0.0.7' OR bugs.version = '0.0.8' OR bugs.version = 'unspecified') AND (bugs.product = 'Server') AND (bugs.bug_status = 'NEW' OR bugs.bug_status = 'ASSIGNED' OR bugs.bug_status = 'REOPENED') AND (bugs.priority = 'P1 - Must Have') Reproducible: Always Steps to Reproduce: Expected Results: To fix this problem I would recommend getting rid of the ability to put commas in milestones and similar fields since we split off of commas.
Matthew -- I don't entirely understand what you did to produce this bug. Is the problem that you can have commas in Target Milestones, or that you can enter a comma in the Query for a Target Milestone? If it's in the Query, is it in the Boolean Charts? If it's any of these behaviors, I would think that we should have the sql_quote filter handle commas, if it doesn't already... -M
*** Bug 237188 has been marked as a duplicate of this bug. ***
*** This bug has been marked as a duplicate of 67036 ***
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.