Closed Bug 206268 Opened 22 years ago Closed 21 years ago

Clicking Go button with a bookmark keyword expression in URL/location bar does search instead

Categories

(Firefox :: General, defect)

x86
All
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: paxunix, Assigned: paxunix)

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4b) Gecko/20030509 Mozilla Firebird/0.6 Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4b) Gecko/20030517 Mozilla Firebird/0.6 You need at least one bookmark with a keyword and the Go button must exist on your button toolbar to verify this. Type in your bookmark keyword expression in the URL/location bar and instead of hitting Enter, click the Go button. Instead of evaluating your bookmark keyword string, your typed text is sent off to your default search engine. Reproducible: Always Steps to Reproduce: Expected Results: Bookmark keyword expression should be evaluated as though Enter had been pressed. It is important that the fix for this does not break middle-click on the Go button (which, if you have things configured that way, would evaluate your bookmark keyword expression in a new tab).
Confirming this one using Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4b) Gecko/20030519 Mozilla Firebird/0.6 => changing to "NEW" since I didn't found a related bug already filed for this problem. Maybe also a toolbar issue?
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 98 → All
This patch changes the go-button oncommand handler to act like the textentered handler for the urlbar. Note that this does not yet mean you can hold Alt and click the Go button to have the entered URL loaded in a new tab (it doesn't work like that right now anyway). It does mean if you type a bookmark keyword expression in the URL bar and click Go, it Does The Right Thing. Could use an r,sr...
Attachment #124659 - Flags: superreview+
Attachment #124659 - Flags: review+
Attachment #124659 - Flags: superreview?
Attachment #124659 - Flags: superreview+
Attachment #124659 - Flags: review?
Attachment #124659 - Flags: review+
Attachment #124659 - Flags: superreview?(blaker)
Attachment #124659 - Flags: superreview?
Attachment #124659 - Flags: review?(blaker)
Attachment #124659 - Flags: review?
Comment on attachment 124659 [details] [diff] [review] Fix go-button oncommand handler to call correct function fix landed
Attachment #124659 - Flags: superreview?(blake)
Attachment #124659 - Flags: superreview+
Attachment #124659 - Flags: review?(blake)
Attachment #124659 - Flags: review+
QA Contact: asa
Assignee: blake → paxunix
Status: NEW → RESOLVED
Closed: 21 years ago
QA Contact: mconnor
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: