Closed Bug 2088 Opened 26 years ago Closed 26 years ago

[PP] Password revealed in form password field

Categories

(Core :: Layout: Form Controls, defect, P2)

x86
Linux
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: slamm, Assigned: pollmann)

References

()

Details

Password characters are not replace with *'s in form password fields. Build stats: ---------------------------------------------------- Linux: The test platform. Windows: The benchmark platform. Both builds from 12-29-98. Linux Red Hat 5.2 egcs-2.90.29 980515 (egcs-1.0.3 release) gtk+-1.1.9 ramiro's nspr rpm with pthreads ../mozilla/configure --enable-debug --with-pthreads 16-bit display
Summary: [PP] Password revealed in form password entry field → [PP] Password revealed in form password field
Assignee: trudelle → karnaze
Assignee: karnaze → pollmann
This works in the widget test program. Someone please look into this. The NS_METHOD nsTextHelper::SetPassword(PRBool aIsPassword) call is never being made by the layout stuff.
Status: NEW → ASSIGNED
When forms create a password input, mIsPassword is passed through InitData, therefore SetPassword is never called. We just need to add this method, as it is in the windows widget. I'll do the work of adding it once I can test again (some recent checkin busted my Linux tree). NS_METHOD nsTextHelper::PreCreateWidget(nsWidgetInitData *aInitData) { if (nsnull != aInitData) { nsTextWidgetInitData* data = (nsTextWidgetInitData *) aInitData; mIsPassword = data->mIsPassword; mIsReadOnly = data->mIsReadOnly; } return NS_OK; }
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Just checked in a fix.
Status: RESOLVED → VERIFIED
verified in 1/26 build.
Inserting Milestone info.
Moving all Widget Set bugs, past and present, to new HTML Form Controls component per request from karnaze. Widget Set component will be retired shortly.
You need to log in before you can comment on or make changes to this bug.