Closed Bug 2150 Opened 26 years ago Closed 25 years ago

GFX coordinate problems, pixel compatability between platforms

Categories

(Core Graveyard :: GFX, defect, P1)

PowerPC
Mac System 8.5

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sdagley, Assigned: waqar)

References

Details

(Keywords: platform-parity)

Due to differing coordinate systems/pen hang items drawn with specific pixel positioned vertices don't draw the same on different platforms NOTE - this bug is supposed to be cc:'ed to saari@netscape.com but he apparently doesn't have a Bugzilla account.
*** Bug 591 has been marked as a duplicate of this bug. ***
Severity: normal → major
how much work is involved in fixing this?
a) finding out where each platform defines a pixel center to be. b) per api *where pixel identity can be defined reasonably in an xp fashion*, finding out where each platform expects vertices to be. c) based on information from a and b, defining in an xp way how gfx expects these to behave. d) making each platform compliant. e) fixing all of the places that break as a result of the changes.
Inserting Milestone info.
Setting all current Open Critical and Major to M3
QA Contact: 2792
setting Eli as QA contact for this bug, to track and review
QA Contact: 2792 → 4130
assigned to incorrect qa -- reassigning to Claudius
Target Milestone: M3 → M4
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → DUPLICATE
*** This bug has been marked as a duplicate of 4363 ***
Status: RESOLVED → REOPENED
Status: REOPENED → ASSIGNED
Resolution: DUPLICATE → ---
Assignee: michaelp → kmcclusk
Status: ASSIGNED → NEW
Target Milestone: M4 → M5
kevin, the pixel coverage has been defined, we just need to make all of the platforms compliant. give me a call and i can pass on the relevant info. x3178.
Target Milestone: M5 → M6
Status: NEW → ASSIGNED
Target Milestone: M6 → M7
Target Milestone: M7 → M8
Target Milestone: M8 → M9
Moving to M9
Ramiro, do we have a document that describes what the policy for pixel coverage is?
Target Milestone: M9 → M10
Moving to M10. This is next on my list after the M9 bugs.
Talked to Michael P. to clarify. He will be forwarding a email discussion which defines the pixel coverage to me. From the phone conversation: drawing a line should not cover the ending pixel. All rendering context calls which take a rect precisely define the pixel coverage through the width and height. All platforms need to honor this. WIN32's varies between fillrect and drawrect.
Target Milestone: M10 → M11
Moving to M11
Created a simple cross platform, pixel coverage test app so we can identify which platforms are not rendering lines and rectangles as expected. It is located in mozilla/gfx/tests/coverage.
Blocks: 4811
Assignee: kmcclusk → dcone
Status: ASSIGNED → NEW
Don, I'm reassigning this to you. Please run the gfx pixel coverage test. Once the coverage is correct on the Mac. Reassign to Ramiro to check Linux.
Assignee: dcone → ramiro
Got the Mac version working and added. Ramiro can you check Linux.
Assignee: ramiro → waqar
reassign to waqar. waqar: this is a pretty simple thing to fix. just make sure the test app runs. i think there were some issues with test apps on linux. pavlov can help you.
Status: NEW → ASSIGNED
Target Milestone: M11 → M14
Target Milestone: M14 → M15
Mass move to M15
Keywords: pp
Summary: [PP] GFX coordinate problems, pixel compatability between platforms → GFX coordinate problems, pixel compatability between platforms
Moving
Target Milestone: M15 → M17
This is fixed, all platforms have this adjustment. I did the final adjustment on Linux and Mac has this fix.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago25 years ago
Resolution: --- → FIXED
marking VERIFIED
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.