Editor mode doesn't work on Linux: - TAB shifts focus between back, forward and urlbar instead of calling Steve's table-resize test event handler - regular key events go to the urlbar even after clicking in the html window I'm not sure whether this is an event problem or something else; I'm investigating further.

Turns out that it's another event problem -- nsWindow::InitCallbacks (which registers handle_key_press_event) does get called, but handle_key_press_event doesn't get called on key presses. Maybe it's a focus problem. Reassigning to joki since he knows more about how key events are supposed to propogate, though I'll also continue to poke around.

The focus issues from the url bar should be fixed.

should we mark this fixed or is there still work to be done?

Don't mark it fixed yet -- editor mode still doesn't work as of yesterday (when I last had a non-crashing build where I could test it). buster checked in some changes that might help, but until I can see their effects I can't say what our status is.

Akkana? Update on this?

Update: progress! Now the events are getting through to the editor, but a lot of the key codes are screwed up. For instance, if I set a breakpoint in nsEditorKeyListener::KeyDown, invoke Tools->Editor Mode, click in the html view type the letter s, then step one line so that we initialize keyCode, it turns out that keyCode is 115, or VK_F4. Likewise, a maps to 97, or VK_NUMPAD1. TAB, gives the correct keycode, 9. Likewise backspace = VK_BACK and delete = VK_DELETE. So far it's just the numeric chars which are wrong.

<-- Typo; I meant "just the alphabetic chars". Numeric chars (e.g. '1') don't register as key events at all.

Turns out nsGtkEventHandler.cpp didn't have code to deal with alphanumeric keys. I've checked in a fix, and editor mode works now.

It works for me, other than the letters I type in appearing in right-to-left order. :) Marking verified.

Inserting Milestone info.

Don't mark it fixed yet -- editor mode still doesn't work as of yesterday (when I last had a non-crashing build where I could test it). buster checked in some changes that might help, but until I can see their effects I can't say what our status is.