User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7 The Firebird options panel inherits the default Windows colours for dialogs. Usually these include white window backgrounds and black window text. For me, these are dark blue backgrounds and white text. This is not a problem for most things, but the selected and mouseover background colours for the sections are light, and they do *not* force the text to be black, so the selected/mouseover'd section text is barely readable. Similarly, the selected group of options in the right panel has a light yellow background, and does not force black text, thus causing the options to be unreadable. Reproducible: Always Steps to Reproduce: 1. Set system colours to white text/dark background (either manually or using a skin that has them) 2. Start Mozilla and go to the Options dialog 3. Expand an option on the right Actual Results: The expanded options were not easily readable, and mousing over an item on the left caused it to be unreadable. Expected Results: If the options dialog is going to force a light background on some things, it should stop assuming that the background is going to be white and that text is going to be black and instead force these things as well (if you're forcing it, at least force everything! ;-). Alternatively it could use a different *system* colour to do so, but it should be careful and choose a colour that will never be unreadable on another. Current skin: Blackcomb Dark, included in WindowBlinds (www.windowblinds.net0 default install.

Confirming.

*** Bug 224730 has been marked as a duplicate of this bug. ***

*** Bug 231024 has been marked as a duplicate of this bug. ***

I was having the same problem. Apparently, it seemes to take the system color I use as a window background, which is white, with the colors I use for menu text (also white). Unreadable, of course, caused by the fact that menu text never appears on the window background. They should use a scheme that does, such as the system's window background and text colors (usually white and black, so no change for most, but it would always be readable).

not critical for 0.9, putting on 1.0 radar

> not critical for 0.9, putting on 1.0 radar Maybe, but this really isn't a difficult bug. I don't see why a two minute fix couldn't be made for 0.9.

"we're accepting patches" is always going to be true. If someone attaches a patch I'll take a look, but this isn't a high-visibility thing to deal with ahead of other things. There are hundreds of open bugs, unless its really critical I doubt that it'll happen for a release that's hopefully less than three weeks away

A two minute fix that maintains an attractive visual appearance for the vast majority of people that use non-clashing color schemes? Just using system colors here isn't going to fly.

Oh, you were talking about the right section of the panel. The problem I have that I described earlier (which was partially inaccurate anyway) concerned the left side. I attached a screen shot with it, and a comparison to notepad, to show the system colors used. All this was on Windows 98. Currently,on Windows 98 at least, the system colors for the left panel seem to go like this: Background: the "Window" setting for background, as used in, for example, Notepad. Text Labels: the "3D Objects" text setting. As this text never occurs naturally on top of the 'Window' backgrounds, problems can occur. I would suggest using the text color set under 'Windows', which always works. I don't know, however, how system colors work on W XP and other OS's is equivalent. If someone could test that for me...

*** Bug 244992 has been marked as a duplicate of this bug. ***

OK, I have a patch for the problem with the left panel. I added a semicolon and color setting in pref.css here. It solves it on my PC. .buttonBoxButton { -moz-appearance: none; border: 1px solid transparent; background-color: transparent; margin-left: 1px; margin-right: 1px; list-style-image: url("chrome://browser/skin/pref/Options.png"); color: WindowText; } Working on the privacy panel.

Changes: Specified text set to "WindowText" on left panel, and set to 'Black' in highlighted area in privacy panel. Needs testing

To test, alter system colors to make left and right panels unreadable, then unzip classic.jar, replace pref.jar with the attachment I made, rezip and replace, and restart Firefox.

Comment on attachment 153934 [details] [diff] [review] Proposed patch. Adds two properties to Pref.css in classic.jar to fix visibility problems in the options and privacy panels for people with unusual system colors. Bug 222799

Comment on attachment 153934 [details] [diff] [review] Proposed patch. This will never get reviewed because it is not a patch. See http://www.mozilla.org/build/unix-cheatsheet.html#makePatch

(In reply to comment #17) > (From update of attachment 153934 [details] [diff] [review]) > This will never get reviewed because it is not a patch. See > http://www.mozilla.org/build/unix-cheatsheet.html#makePatch > Sorry, I didn't know. Still don't. Those are the fixes I made; if anyone who knows how to register that knows how, go ahead.

Comment on attachment 154281 [details] [diff] [review] patch Based on comment 8, I ask Mike Connor for review.

Can someone confirm the fix for this?

The patch that was checked into the trunk fixes this problem in the Privacy panel. (I tested by switching to High Contrast mode, left Alt + left Shift + PrintScreen.) Was it also checked into the trunk?

You say privacy panel... the other part was checked in, right? The added WindowText property to fix the side panel?

*** Bug 272793 has been marked as a duplicate of this bug. ***

Fixed on the aviary branch 2004-10-12 20:05. Fixed on trunk by the branch landing.

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change