Closed Bug 222896 Opened 21 years ago Closed 20 years ago

downloading of truncated messages doesn't work if pop3 server and/or user names have been modified (serverx.realHostName / serverx.realUserName exist in profile)

Categories

(MailNews Core :: Networking: POP, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: fruli, Assigned: Bienvenu)

References

()

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT; rv:1.5b) Gecko/20030827 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT; rv:1.5b) Gecko/20030827 Downloading truncated messages doesn't work if the pop3 server name and / or user name of a mail account have been changed, i.e. if mail.server.serverX.realuserName and or mail.server.serverX.realhostName exist in the account for serverX. The download link should be "pop://<mail.server.serverX.realuserName>@<mail.server.serverX.realhostName>:<mail.server.serverX.port>/?uidl=<xxxxx>" instead of "pop://<mail.server.serverX.userName>@<mail.server.serverX.hostName>:<mail.server.serverX.port>/?uidl=<xxxxx>" which is currently used by Mozilla and does not work. Reproducible: Always Steps to Reproduce: 1. Create a pop3 account and limit download message size for the account 2. Change the pop3 server name and/or the pop3 user name 3. Retrieve a message whose size exceeds the download message size limit for the account 4. Try to download the message manually afterwards by clicking on the respective link in the truncated message displayed. 5. Download doesn't work since the original pop3 server name / pop3 user name are used for the download link instead of the modified ones. Actual Results: download of truncated messages does not work. Expected Results: Mozilla should use the modified pop3 server name / pop3 user name for the download link, i.e. use the mail.server.serverX.realhostName and/or mail.server.serverX.realuserName for the download link if they exist in the profile for serverX.
taking, thx for the good diagnosis - I'll look into it.
Status: UNCONFIRMED → NEW
Component: Offline → Networking: POP
Ever confirmed: true
Attached patch proposed fix for user name part (deleted) — Splinter Review
this fixes the username problem. It shouldn't fix the server name problem, but I was not able to recreate the server name problem...
Attachment #135340 - Flags: superreview?(mscott)
also, FYI, the download link shouldn't change - it should use the original user and server name because that's the uri for the server, and changing the user/server name doesn't change the uri. The problem is that we need to make sure we use the real user name when talking to the server.
Attachment #135340 - Flags: superreview?(mscott) → superreview+
The problem is not that the download link is not changed for old messages but that the download link is made up of the old username and the old servername for messages not beeing completely downloaded from the new server with the new username.
No, again, the link shouldn't change for new or old messages (the link is inserted when we display the message, so there's really no distinction between old and new messages). When you rename a server or change the user name, we still keep the old server name and user name around, and we use the old user name and server name to find the right server object to use, and that server object has the "real" user name and host name. Can you try today's build and see if it works? I was not able to reproduce the problem when just the host name changed, however...
while sitting in the dentist chair, it occurred to me that this might be a problem with popstate.dat, which also is keyed on the server name - does this problem occur on both messages loaded before and after the server name changed?
I looked at popstate.dat - it has the old server name (the original server name) and that seems to work fine. So I'm at a loss why the server name change would cause problems. I've fixed the user name change problem.
To Comment #7 From David Bienvenu : > I looked at popstate.dat - it has the old server name > (the original server name) and that seems to work fine. I confirmed this by simple test with Thunderbird 0.5a (2003-12-16/Win-Me). Following is my test results. (1) Deleted ...\Application Data\Thunderbird directry (2) Defined completely new profile (3) Defined an POP3 account with dummy POP server name and Dummy username and Dummy SMTP server name (4) Shutdowned and restarted Thunderbird (5) Changed POP server name to real POP server name (relhostname/realusername are created in prefs.js) (6) Changed SMTP server name to real SMTP server name (7) Sent a long mail to myself and received it (8) Truncated mail was received and "Click here" link appeared. popstat.dat was as follows ; (server name and username is dummy one - ) ( servername/username instead of realusername/realservername) > # POP3 State File > # This is a generated file! Do not edit. > > *Dummy.POP.Server m-wada > b 4b011662ceae30d82ae6d57aa21e2067 1072163388 (9) When I clicked "Click Here", whole mail were downloaded successfully and popstat.dat was cleared ; > # POP3 State File > # This is a generated file! Do not edit. On server name change by user from UI, Thunderbird(Mozilla also) adds or changes realservername and realusername but will not modify servername and username. servername and username is always the value user specified on initial account definition. Therefore, I also think servername or username change will not affect on server choice for additional download. Possible case I can imagine is only "User(or other software) changed servername or username in prefs.js directly" case, user error though. However, if mail server physically transfered to other system, for example, MS Windows machine to Unix machine, pointer to the mail kept in popstat.dat maybe become obsolete. David Bienvenu, is this possible?
WADA, I think what you're saying is right. Basically, I'm not able to reproduce this problem after my fix went in for the username. However, if you manually edit prefs.js or popstate.dat, then you could potentially get into trouble.
I'm not able to reproduce this. Can anyone reproduce this with 1.6? Or tbird .5?
no response; marking wfm.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → WORKSFORME
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: