Closed
Bug 2255
Opened 26 years ago
Closed 26 years ago
Large-dimensioned PNG files crash Mac viewer (memory related)
Categories
(Core Graveyard :: Viewer App, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M4
People
(Reporter: elig, Assigned: pnunn)
References
()
Details
* TITLE/SUMMARY
[PP] Large-dimensioned PNG files crash Mac viewer
* STEPS TO REPRODUCE
0) Launch Viewer using any of the following images from http://jazz/users/pnunn/
publish/pngpix/
- 6666.png
- BBlue.png (workis on debug build)
- BIG2.png
* RESULT
- What happened
Freeze. Can't even move mouse pointer or go into Macsbug. No error log or
anything (including on Debug build, pulled on 1.4.98).
Note that all of these images have large *dimensions*, not necessarily large
image sizes. i.e. BBlue.png is just a 5K file of blue pixels.)
I'll try this using some large GIF and JPEG images, see what happens, and append
the results to this bug report.
- What was expected
Mac shouldn't freeze.
* REGRESSION
- Occurs On
viewer (1.8.98 build for Mac OS; 10 MB RAM partition)
- Doesn't Occur On
viewer (1.7.98 build for Win32)
viewer (1.8.98 build for Linux)
* CONFIGURATIONS TESTED
- PowerMac 8500/120 (233 Mhz 604e), 64 MB RAM, 1024x768 (16-bit video), Mac OS
8.5.1
Reporter | ||
Updated•26 years ago
|
Assignee: rickg → sdagley
Reporter | ||
Comment 1•26 years ago
|
||
Checked a large (1000x800) JPG image file (located at http://www2.jpl.nasa.gov/
files/images/hi-res/p46411.jpg), and it didn't crash the Mac viewer.
(Of course, it didn't *load*, either, just stopped at 0K...unsure if that problem
is related to 2094. Will find out...)
Updated•26 years ago
|
Assignee: sdagley → pnunn
Comment 2•26 years ago
|
||
Image bugs to pnunn, cc: to michaelp
Reporter | ||
Comment 3•26 years ago
|
||
I believe that this issue is memory-related. When I raise Viewer's partition to
20 MB (from 10 MB), all but BIG2.png displays.
Reporter | ||
Updated•26 years ago
|
Summary: [PP] Large-dimensioned PNG files crash Mac viewer → [PP] Large-dimensioned PNG files crash Mac viewer (memory related)
Updated•26 years ago
|
Severity: major → normal
Updated•26 years ago
|
Assignee: sdagley → pnunn
Comment 7•26 years ago
|
||
No crash observed with build from last week but memory allocation goes up
considerably when viewing the image. Not that I want to play bug ping pong but
do we really need 8MB to display the BIG2.png image? If so, we should handle the
error gracefully if we can't allocate enough memory.
When I can get a mac build that runs long enough
to debug, I'll check into this. I don't think this
is an imglib problem, or else the other platforms
would have the same problem.
Reporter | ||
Comment 9•26 years ago
|
||
[Just FYI, this bug no longer takes place as of the 2.12.99 Mac OS build and
appears to be fixed.
Pam or Steve, please share whether you'd like this bug to be Resolved, or if
you'd like to keep it open for any kind of investigation.
Thanks!]
Updated•26 years ago
|
Priority: P1 → P3
Summary: [PP] Large-dimensioned PNG files crash Mac viewer (memory related) → Large-dimensioned PNG files crash Mac viewer (memory related)
Comment 10•26 years ago
|
||
Dropping the priority level and removing [PP] as this bug isn't currently
manifesting itself but pam indicated she'd like to review it once we reach the
dogfood/more stable phase.
Assignee | ||
Comment 11•26 years ago
|
||
Steve:
After our hallway talk yesterday, something
kept nagging me.
I finally realized what seemed wrong. The image
library doesn't need to allocate the buffer for the
whole image. We handle the image line by line.
Mac pict images require you have the whole
image before decoding, but this isn't true of the
image we support.
I think we need to look at this some more.
-pn
Updated•26 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Comment 12•26 years ago
|
||
Marking as fixed since the bug is no longer reproducable and elig's testing
indicates there is similiar memory usage with a JPEG version of the image.
Assignee | ||
Comment 13•26 years ago
|
||
closing this is ok with me.
-pn
Reporter | ||
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 14•26 years ago
|
||
Since both Steve & Pam consent, marking as verified. Thanks!
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•