Closed Bug 2330 Opened 26 years ago Closed 26 years ago

[BLOCK] Bookmarks file crashes viewer

Categories

(Core Graveyard :: Tracking, defect, P1)

x86
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: michael.j.lowe, Assigned: waterson)

Details

The following bookmark file crashes the viewer during parsing in nsBookmarkDataSource.cpp. <!DOCTYPE NETSCAPE-Bookmark-file-1> <!-- This is an automatically generated file. It will be read and overwritten. Do Not Edit! --> <TITLE>Bookmarks for Michael Lowe</TITLE> <H1>Bookmarks for Michael Lowe</H1> <DL><p> <DT><A HREF="http://www.mozilla.org/" ADD_DATE="916250608" LAST_VISIT="916250605" LAST_MODIFIED="916250605"><<< mozilla.org >>></A> <DD>&lt;&lt;&lt; >>> </DL><p>
By the way, this test file was generated by Communicator 4.5 and is parsed correctly by this program without problems.
Status: NEW → ASSIGNED
Okay. I'll look at this. The bookmark parser in RDF is toy code right now.
Setting all current Open Critical and Major to M3
per leger, assigning QA contacts to all open bugs without QA contacts according to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Summary: Bookmarks file crashes viewer → [BLOCK] Bookmarks file crashes viewer
We need better bookmark parsing for dogfood. Changing summary to [BLOCK].
Component: Viewer App → Apprunner
QA Contact: 3853 → 3849
Setting component to Apprunner. beppe, please update QA Contact...thanks!
keeping myself as QA contact for now, the appropriate QA engineer is on vacation.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Rolled forward the 4.5 bookmark parser code, which is line-based and probably much more robust than the previous implementation. It parses slamm's bookmarks file anyway :).
Status: RESOLVED → VERIFIED
copied the code into a file, and accessed it through 3/16 build of apprunner, the app worked fine and did not crash
Moving all Apprunner bugs past and present to Other component temporarily whilst don and I set correct component. Apprunner component will be deleted/retired shortly.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.