Closed Bug 2343 Opened 26 years ago Closed 26 years ago

Font prefs broken because prefs not initialized

Categories

(Core Graveyard :: Tracking, defect, P1)

x86
Windows 98
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: teruko, Assigned: rpotts)

References

Details

Tested Jan 12 Win32 build. No preferences to set fonts to display I18n pages.
Status: NEW → ASSIGNED
Setting all current Open Critical and Major to M3
Component: Preferences → Pref UI
Product: MozillaClassic → Browser
Changing product to Browser
per leger, assigning QA contacts to all open bugs without QA contacts according to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
frank, what is the latest status on this?
Assignee: ftang → rpotts
Status: ASSIGNED → NEW
Summary: [I18n] No preferences to set fonts. → No preferences to set fonts.
This bug is not about do we have a font pref dialog box or not but does layout code pick up a font pref from the pref file. It is work in Viewer but not apprunner. In viewer, nsWebShell pass nsIPref to DocumentViewerImpl and pass to nsPrefsContext through Init method. But in apprunner those value are always null because no call call nsWebShell:SetPrefs. In viewer, nsBrowserWindow create the webShell and call the SetPrefs method to pass in the nsIPrefs. In apprunner, nsWebShellWindow::Initialize create the webShell but does not load a nsIPref and call the SetPrefs method. (actually it is there but comment out, see line 236 of xpfe/appshell/src/nsWebShellWindow.cpp Reassign this to rpotts since cvs blame show he is the last one touch that line... rpotts, please reassign to the right person in xp app if you are not the right person to work on this.
*** Bug 3759 has been marked as a duplicate of this bug. ***
Assignee: rpotts → ftang
Re-assigned to ftang@netscape.com. Frank, Rick isn't available today. Why don't you try uncommenting that line and see if it works.
Assignee: ftang → rpotts
rick sez he can fix this if hubie has not already fixed.
Component: Pref UI → Apprunner
Summary: No preferences to set fonts. → Font prefs broken because prefs not initialized
Changed summary and component to Apprunner.
Status: NEW → ASSIGNED
I've checked in the code to nsAppRunner.cpp to initialize the prefs from "prefs.js". I've also changed nsWebShellWindow.cpp to provide the webshell with an nsIPref interface after initialization... I don't have any test case to verify that this fixes the problem :-( -- rick
Well I guess this is redundant, but it shouldn't hurt (in the sense that things won't break). Prefs gets initialized to a default file if it hasn't been initialized before. I can see some confusion if the two files being read in are not the same, as changes in one could be modified by changes in the other. It's probably best for M3 if we rely on prefs reading in the file itself so there is no confusion.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Resolved as FIXED. Rick, this is fixed but you just can't verify it, right?
I saw it in the 3-16 build and my latest tree. teruko, please verify this
So there isn't any confusion, the pref file being read on the various platforms is: win: prefs.js mac: Netscape Preferences unix: preferences.js For M3 they are being read from the current working directory. This will change shortly after M3.
QA Contact: 3819 → 3851
changing qa contact to teruko
QA Contact: 3851 → 3819
reassigning back to paulmac, it was a mistake
Status: RESOLVED → VERIFIED
prefs in general now working. marking verified. can't speak for font prefs in particular however.
Moving all Apprunner bugs past and present to Other component temporarily whilst don and I set correct component. Apprunner component will be deleted/retired shortly.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.