Closed
Bug 2343
Opened 26 years ago
Closed 26 years ago
Font prefs broken because prefs not initialized
Categories
(Core Graveyard :: Tracking, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
M3
People
(Reporter: teruko, Assigned: rpotts)
References
Details
Tested Jan 12 Win32 build.
No preferences to set fonts to display I18n pages.
Updated•26 years ago
|
Status: NEW → ASSIGNED
Updated•26 years ago
|
Component: Preferences → Pref UI
Product: MozillaClassic → Browser
Comment 2•26 years ago
|
||
Changing product to Browser
Comment 3•26 years ago
|
||
per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Comment 4•26 years ago
|
||
frank, what is the latest status on this?
Updated•26 years ago
|
Assignee: ftang → rpotts
Status: ASSIGNED → NEW
Summary: [I18n] No preferences to set fonts. → No preferences to set fonts.
Comment 5•26 years ago
|
||
This bug is not about do we have a font pref dialog box or not but does layout
code pick up a font pref from the pref file.
It is work in Viewer but not apprunner.
In viewer, nsWebShell pass nsIPref to DocumentViewerImpl and pass to
nsPrefsContext through Init method. But in apprunner those value are always null
because no call call nsWebShell:SetPrefs.
In viewer, nsBrowserWindow create the webShell and call the SetPrefs method to
pass in the nsIPrefs.
In apprunner, nsWebShellWindow::Initialize create the webShell but does not load
a nsIPref and call the SetPrefs method. (actually it is there but comment out,
see line 236 of xpfe/appshell/src/nsWebShellWindow.cpp
Reassign this to rpotts since cvs blame show he is the last one touch that
line...
rpotts, please reassign to the right person in xp app if you are not the right
person to work on this.
Re-assigned to ftang@netscape.com.
Frank, Rick isn't available today. Why don't you try uncommenting that line and
see if it works.
Updated•26 years ago
|
Assignee: ftang → rpotts
Comment 8•26 years ago
|
||
rick sez he can fix this if hubie has not already fixed.
Component: Pref UI → Apprunner
Summary: No preferences to set fonts. → Font prefs broken because prefs not initialized
Assignee | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•26 years ago
|
||
I've checked in the code to nsAppRunner.cpp to initialize the prefs from
"prefs.js". I've also changed nsWebShellWindow.cpp to provide the webshell with
an nsIPref interface after initialization...
I don't have any test case to verify that this fixes the problem :-(
-- rick
Comment 11•26 years ago
|
||
Well I guess this is redundant, but it shouldn't hurt
(in the sense that things won't break). Prefs gets
initialized to a default file if it hasn't been
initialized before.
I can see some confusion if the two files being read
in are not the same, as changes in one could be modified
by changes in the other.
It's probably best for M3 if we rely on prefs reading
in the file itself so there is no confusion.
Comment 12•26 years ago
|
||
Resolved as FIXED.
Rick, this is fixed but you just can't verify it, right?
Comment 13•26 years ago
|
||
I saw it in the 3-16 build and my latest tree. teruko, please verify this
Comment 14•26 years ago
|
||
So there isn't any confusion, the pref file being read
on the various platforms is:
win: prefs.js
mac: Netscape Preferences
unix: preferences.js
For M3 they are being read from the current working directory.
This will change shortly after M3.
Comment 15•26 years ago
|
||
changing qa contact to teruko
Comment 16•26 years ago
|
||
reassigning back to paulmac, it was a mistake
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Comment 17•26 years ago
|
||
prefs in general now working. marking verified. can't speak for font prefs in
particular however.
Comment 18•26 years ago
|
||
Moving all Apprunner bugs past and present to Other component temporarily whilst
don and I set correct component. Apprunner component will be deleted/retired
shortly.
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•