Closed Bug 2348 Opened 26 years ago Closed 26 years ago

[PP] Crash on Netscape Search (form button)

Categories

(Core Graveyard :: Viewer App, defect, P1)

PowerPC
Mac System 8.5

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: elig, Assigned: pierre)

References

Details

* TITLE/SUMMARY [PP] nsSelectControlFrame should check for Null before... * STEPS TO REPRODUCE 0) Launch Viewer 1) Surf to www.netscape.com 2) Click on the "Search" button * RESULT - What happened Crash. (Stack crawl enclosed; Pierre, if you're around tonight, Simon left his Mac with the debugger at this crash.) - What was expected According to Mr. Dagley, in nsSelectControlFrame::GetNamesValues, we should be checking for Null before doing a QueryInterface on mWidget. * REGRESSION - Occurs On viewer (1.13.99 optimized build for Mac OS) - Doesn't Occur On viewer (1.12.99 optimized build for Win32; had to go to http:// www1.netscape.com/index.html, since it wouldn't load www.netscape.com) - Haven't Checked viewer (1.13.99 build for Linux --- build is broken, so haven't checked) * CONFIGURATIONS TESTED - PowerMac 8500/120 (233 Mhz 604e), 64 MB RAM, 1024x768 (16-bit video), Mac OS 8.5.1 * MACSBUG LOG Calling chain using A6/R1 links Back chain ISA Caller 00000000 PPC 0B10E610 03ACF200 PPC 0B1052E4 03ACF1A0 PPC 0B104BD0 03ACF160 PPC 0ADD73FC nsMacMessageSink::DispatchMenuCommand(EventRecord&, long)+004FC 03ACF080 PPC 0ADD780C nsMacMessageSink::DispatchMenuCommand(EventRecord&, long)+0090C 03ACF020 PPC 0ADD7C84 nsMacMessageSink::DispatchMenuCommand(EventRecord&, long)+00D84 03ACEFD0 PPC 0ADD7F18 nsMacMessageSink::DispatchMenuCommand(EventRecord&, long)+01018 03ACEF90 PPC 0ADD6EE4 nsMacMessageSink::DispatchOSEvent(EventRecord&, GrafPort*)+00040 03ACEF40 PPC 0ADD4F38 NS_GetWidgetNativeData(nsISupports*, void**)+0BFB8 03ACEEE0 PPC 0ADD50D0 NS_GetWidgetNativeData(nsISupports*, void**)+0C150 03ACEEA0 PPC 0ADD55A8 NS_GetWidgetNativeData(nsISupports*, void**)+0C628 03ACEE20 PPC 0ADD5FC8 NS_GetWidgetNativeData(nsISupports*, void**)+0D048 03ACEDD0 PPC 0ADC4408 03ACED70 PPC 0ADC4390 03ACED30 PPC 0ADC4308 03ACECE0 PPC 0AB7FDA0 NSGetFactory+02834 03ACEC90 PPC 0AB7E998 NSGetFactory+0142C 03ACEB80 PPC 0AB8149C NSGetFactory+03F30 03ACEB10 PPC 0AC39C00 NS_NewPresShell(nsIPresShell**)+022F8 03ACEAB0 PPC 0AD3198C NSGetFactory+06FD4 03ACEA50 PPC 0AD344C4 NSGetFactory+09B0C 03ACE9E0 PPC 0AD2EDF0 NSGetFactory+04438 03ACE7F0 PPC 0AD2F394 NSGetFactory+049DC PowerPC access exception at 9331B434
Status: NEW → ASSIGNED
Summary: [PP] (Netscape Search) nsSelectControlFrame should check for Null → [PP] Crash on Netscape Search
I see the crash (you can restart your machine) but I disagree with the fix. Checking for null does prevent from crashing but results in a bad URL being sent to the host. Changed the title / Marked "assigned".
Summary: [PP] Crash on Netscape Search → [PP] Crash on Netscape Search (form button)
(Thanks, Pierre.)
FMI, it doesn't crash on all forms. On Yahoo, for instance, we can enter a Zip code and click "Enter Zip Code".
*** Bug 2617 has been marked as a duplicate of this bug. ***
*** Bug 2619 has been marked as a duplicate of this bug. ***
www.metacrawler.com appears to have a similar problem.
On my PbookG3 with Jan 25 - PPC Mem exception at NS_NewNameSpaceManager, crawl appears same as Eli's.
Sorry, I meant to say in my last entry it was the Mac Jan 22 build.
Is this Mac only? Happen on Win and Linux too?
Works fine on 1.25.99 Linux build. (Win32 results already listed in "Regression" section of bug report, nyah nyah nyah... :-p)
doesn't crash on 1/27 linux build.
Inserting Milestone info.
Setting all current Open Critical and Major to M3
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
think this is fixed with pierre's latest check-in. lets test and re-open if we still have the problem.
I confirm: it's been fixed by my last checkin. I had just forgotten about this bug report... I thought I was working on #2208 "Form controls don't work" which is not ready for prime time yet.
elig...verify this one when you get a sec please. Thanks!
Unfortunately, we do not presently have a working debug build which contains this fix. (2.21.99 build won't accept URLs, and 2.18.99 build doesn't appear to contain the fix.) Will check using today or tomorrow's build.
*** Bug 3164 has been marked as a duplicate of this bug. ***
Status: RESOLVED → VERIFIED
Verified fixed using 3.9.99 build of Seamonkey on Mac (apprunner).
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.