This is subtly different from 179256. I've been using the patch system more in the past couple of days and here's what I think should happen when I attach a patch: If I attach a new patch that obsoletes an old one: (1) pending (?) review requests are cleared on the obsolete patch and added to the new patch. Clearing the old ? request tidies up the view a bit. (2) review- annotations are added as review? requests on the new patch (3) review+ annotations are added as review? requests on the new patch (this is perhaps the default behavior, with the "bring forward review" Aaron talks about in 179256 as a checkbox option in the create page) (1) alone would be a huge benefit.

Item #1 is bug 180652. I don't believe we have any bugs filed for 2 and 3 yet though.

Actually, item #1 is bug 180833. 180652 is only about cancelling the pending request on obsoleting.

Morphing to cover items 2) and 3) in the list.

I'm not convinced with points 2) and 3). Not taking it for the moment, myk. ;)

2) and 3) would be huge benefits for the most common case (reattaching a patch after reviewed). This should only happen for patches, not for other types of attachments.