Closed Bug 2423 Opened 26 years ago Closed 25 years ago

Plug-in doesn't receive data

Categories

(Core Graveyard :: Plug-ins, defect, P2)

x86
Windows NT
defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: cohn, Assigned: serhunt)

Details

(Whiteboard: 4/1: Requested developer to verify)

nsPluginStreamListener doesn't necessarily pass data to the plugin. The implementation requires that OnProgress be called before OnDataAvailable since OnProgress sets up the peer. However, OnProgress gets called before OnStartBinding, and it's during OnStartBinding that the nsPluginStreamListener gets created. So the nsPluginStreamListener never does get the OnProgress call. My solution was to always set up the peer in nsPluginStreamListener::OnStartBinding: <! if ((PR_TRUE == mGotProgress) && (nsnull == mPeer) && !> // RC: possible that OnProgress happened before listener is set up !> // in that case, if we don't set up now, we'll get OnDataAvailable with no peer set to receive it !> if (/*(PR_TRUE == mGotProgress) &&*/ (nsnull == mPeer) &&
Status: NEW → ASSIGNED
We're actually in the midst of making a big change to how streams are done in the new Plugin API - it involves communicating with the plugin entirely through a StreamListener type of interface. It's also a bug in netlib that OnProgress() gets called before OnStartBinding(). I'll report it to the netlib folks. But meanwhile, I'll test and hopefully check in your fix soon. Thanks!
Setting all current Open/Normal to M4.
per leger, assigning QA contacts to all open bugs without QA contacts according to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
QA Contact: 3849 → 4082
reassigning Greg Lynn as QA contact
QA Contact: 4082 → 4015
QA assigned set to whitebox, gerardok.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
This should be fixed in the latest build.
cohn, I don't know how to reproduce the failure caused by this bug. Please can you mark it as verified or provide a testcase to verify it? Thanks!
I'm not in a position right now where I can update to the latest build, and I probably won't be for about two weeks. And I don't have a simple test case, just my plugin that I can't release yet. I will verify the fix when I'm able to update to the current build.
Alex, please could you verify this bug or provide a testcase to verify it. The bug description does not specify how to reproduce the application failure. Thanks!
Whiteboard: 4/1: Requested developer to verify
Status: RESOLVED → REOPENED
Sorry for the delay, but I was finally able to verify that this problem is still there. The same fix works. OnProgress is still getting called before OnStartBinding. We now have a pre-alpha version of our plug-in that we can hand out under NDA if that's of interest to you.
Resolution: FIXED → ---
Target Milestone: M4 → M7
this is a M4 bug which was re-opened and we are now on M7. Moving to M7.
Status: NEW → ASSIGNED
Target Milestone: M8 → M11
Target Milestone: M11 → M14
The Necko landed since the last comment. Could you please verify it still there and provide with a test case?
This code is no longer relevant. Marking invalid.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago25 years ago
Resolution: --- → INVALID
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.