Closed
Bug 2423
Opened 26 years ago
Closed 25 years ago
Plug-in doesn't receive data
Categories
(Core Graveyard :: Plug-ins, defect, P2)
Tracking
(Not tracked)
RESOLVED
INVALID
M14
People
(Reporter: cohn, Assigned: serhunt)
Details
(Whiteboard: 4/1: Requested developer to verify)
nsPluginStreamListener doesn't necessarily pass data to the plugin. The
implementation requires that OnProgress be called before OnDataAvailable since
OnProgress sets up the peer. However, OnProgress gets called before
OnStartBinding, and it's during OnStartBinding that the nsPluginStreamListener
gets created. So the nsPluginStreamListener never does get the OnProgress call.
My solution was to always set up the peer in
nsPluginStreamListener::OnStartBinding:
<! if ((PR_TRUE == mGotProgress) && (nsnull == mPeer) &&
!> // RC: possible that OnProgress happened before listener is set up
!> // in that case, if we don't set up now, we'll get OnDataAvailable with no
peer set to receive it
!> if (/*(PR_TRUE == mGotProgress) &&*/ (nsnull == mPeer) &&
Updated•26 years ago
|
Status: NEW → ASSIGNED
Comment 1•26 years ago
|
||
We're actually in the midst of making a big change to how streams are done in the
new Plugin API - it involves communicating with the plugin entirely through a
StreamListener type of interface.
It's also a bug in netlib that OnProgress() gets called before OnStartBinding().
I'll report it to the netlib folks.
But meanwhile, I'll test and hopefully check in your fix soon. Thanks!
Comment 3•26 years ago
|
||
per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Updated•26 years ago
|
QA Contact: 3849 → 4082
Comment 4•26 years ago
|
||
reassigning Greg Lynn as QA contact
Updated•26 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Comment 6•26 years ago
|
||
This should be fixed in the latest build.
cohn, I don't know how to reproduce the failure caused by this bug. Please
can you mark it as verified or provide a testcase to verify it? Thanks!
Reporter | ||
Comment 8•26 years ago
|
||
I'm not in a position right now where I can update to the latest build, and I
probably won't be for about two weeks. And I don't have a simple test case, just
my plugin that I can't release yet. I will verify the fix when I'm able to
update to the current build.
Alex, please could you verify this bug or provide a testcase to verify it. The
bug description does not specify how to reproduce the application failure.
Thanks!
Reporter | ||
Updated•25 years ago
|
Status: RESOLVED → REOPENED
Reporter | ||
Comment 10•25 years ago
|
||
Sorry for the delay, but I was finally able to verify that this problem is
still there. The same fix works. OnProgress is still getting called before
OnStartBinding. We now have a pre-alpha version of our plug-in that we can hand
out under NDA if that's of interest to you.
Comment 11•25 years ago
|
||
this is a M4 bug which was re-opened and we are now on M7. Moving to M7.
Assignee | ||
Comment 12•25 years ago
|
||
The Necko landed since the last comment. Could you please verify it still there
and provide with a test case?
Assignee | ||
Comment 13•25 years ago
|
||
This code is no longer relevant. Marking invalid.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago → 25 years ago
Resolution: --- → INVALID
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•