Closed Bug 24478 Opened 25 years ago Closed 23 years ago

View image should put Width x Height in the title of window

Categories

(Core :: Layout, defect, P2)

x86
All
defect

Tracking

()

RESOLVED WORKSFORME
mozilla1.2alpha

People

(Reporter: marshall, Assigned: attinasi)

References

Details

(Keywords: regression)

In Nav 4 when you view an image, it places the width and height of the image in the <title>. This is VERY useful when you are typing up html pages and you need to specify the width="" height="" attributes.
Assignee: chofmann → don
is this webshell?
No, this is a layout issue. Someone lower down in layout needs to create and pass up/ set a title.
duh, marking layout. over to rickg for a look. m15.
Assignee: don → rickg
Component: other → Layout
Target Milestone: M15
Marc -- here's a bug to go along with the source I gave you.
Assignee: rickg → attinasi
Status: NEW → ASSIGNED
The title needs to be set AFTER the document is setup as an observer - fix pending.
Sorry - I mixed up the last description: The title needs to be set AFTER the <I>webshell</I> is setup as an observer of the <I>document</I> - checkin pending review.
Fixed: changed one file, nsImageDocument.cpp. NOTE: sometimes the image dimensions are reported as width=0 and length=0, in which case there is no 'Width x Height' put into the title, just the text 'Image'. nsIImageRequest interface docs says of GetNaturalDimensions() method: "Returns the natural dimensions of the image. Returns 0,0 if the dimensions are unknown."
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
*** Bug 5707 has been marked as a duplicate of this bug. ***
Adding verifyme keyword.
Keywords: verifyme
The title is NOT changed under Linux build 2000021715. View Image has a title of just "Mozilla".
It works for me on Linux, using a developer-build from 2/16. I'll try to test it on the published daily builds available from mozilla.org to see what's up. The change should not be platform-dependent in any way... (famous last words)
On my Win98 2000021808, the title changes AFTER the image finished loading. This should be done at the beginning of the loading process. Reopening bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
The dimensions are not known until AFTER the image is loaded, so I cannot update the title until then. Marking back to fixed.
Its not displaying the widths and heights anymore.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Fix in hand, will checkin after getting reviewed.
Status: REOPENED → ASSIGNED
Keywords: verifyme
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
Updating QA Contact.
Status: RESOLVED → VERIFIED
QA Contact: leger → petersen
REOPEN. The window title does not change if I: 1. load this bug report 2. "View Image" on the Bugzilla banner image at the top. ACTUAL: Title does not change after 2. EXPECTED: Title should display image type (GIF) and size (as it does in Nav 4.x). ADDITIONAL INFO: The title changes correctly if I do a SHIFT+RELOAD, but not if I only do a RELOAD, after 2.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
mats - what build are you using? It is working for me...
In 200107230/win98 I am seeing this regression as well. Try this: Go to any page (this page will do). [Location 1] View image on an image. (Note that the title of the image page is the same as the previous page, Location 1). Type a new location into the location toolbox; wait for that to load. [Location 2] Press back. (Note that the title of the image page is the same as Location 2!)
I'm seeing this on the branch build, 07-23. I'll search for the cause of the regression now.
Status: REOPENED → ASSIGNED
Keywords: regression
Priority: P3 → P2
Target Milestone: M15 → mozilla0.9.2
07-20 build works, 07-21 and later builds do not (branch). Doing the CVS-log trawl now... In the code, what I see is that the ImageListener's OnStopRequest never gets called when the 'View Image' is done - so, the ImageDocument never gets its clue to update the title.
Hmm. Now I'm not so convinced. I am finding this to be very intermittent. On the 07-23 branch build, for example, I can load www.mozilla.org, right-click on the banner-picture and select 'View Image' and get the image dimensions in the title bar. I press 'back' and try it again and it works for 15 times, then it fails. Likewise on the images on the netscape.com home page: I view image the little ad in the top-right corner, and sometimes it works and sometimes it doesn't. I repeated this fun exercise with 07-20, 07-21, and 07-23 builds from the branch, as well as a CVS build from the branch built today (07-23) at ~14:00. QA assistance would really be helpful here :)
Marc, sorry for not mentioning the build id, I was using 2001072003: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.2+) Gecko/20010720 I have tried an older build 2001061804 and it also did not change the title, not even after a SHIFT+RELOAD.
Milestone reality check.
Target Milestone: mozilla0.9.2 → mozilla0.9.4
*** Bug 88051 has been marked as a duplicate of this bug. ***
*** Bug 96014 has been marked as a duplicate of this bug. ***
Target Milestone: mozilla0.9.4 → mozilla1.0
It seems to work for some images though, here is one: http://bonsai.mozilla.org/bonsai.gif
That example really works.. does that mean it is related to the .gif or .jpg itself?
This is working for me all the time, except for some reason I get a rare occurance of the title just not changing *at all* when I do View Image from the context menu. If I click a link to an image, or type / paste the image URL inthe location bar it always works.
*** Bug 103822 has been marked as a duplicate of this bug. ***
Target Milestone: mozilla1.0 → mozilla1.2
This WORKSFORME (WinME 2001120108)
*** Bug 113080 has been marked as a duplicate of this bug. ***
*** Bug 77378 has been marked as a duplicate of this bug. ***
WFM, 2002-01-25-03 (trunk) on Windows 98 SE. Can anyone still reproduce this bug?
Seems also WFM under MacOS 8.6 2002012503
WFM 2002012503/WinNT4
WORKSFORME, 2002-01-27-06 (trunk) on Linux.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago23 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.