Closed
Bug 250547
Opened 20 years ago
Closed 20 years ago
FlagTypes uses DB dependent comma operator
Categories
(Bugzilla :: Creating/Changing Bugs, enhancement)
Bugzilla
Creating/Changing Bugs
Tracking
()
RESOLVED
FIXED
Bugzilla 2.20
People
(Reporter: Tomas.Kopal, Assigned: Tomas.Kopal)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jouni
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040528 Debian/1.6-7
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040528 Debian/1.6-7
As reported and fixed in bug 228917, comma operator can be DB specific. In
Bugzilla/FlagTypes.pm, there is another occurence, which should be replaced by
INNER JOIN. Patch follows.
Reproducible: Always
Steps to Reproduce:
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Comment 2•20 years ago
|
||
Comment on attachment 152677 [details] [diff] [review]
Patch replacing comma operator with INNER JOIN
I don't think the comment change was necessary... it's still joining by flag
type, and the comment doesn't need to get technical :)
Otherwise this looks good, except that I can't get the patch to apply. I get
an error about "unexpected end of file" and the patch fails.
Attachment #152677 -
Flags: review-
Updated•20 years ago
|
Assignee: myk → Tomas.Kopal
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 2.20
Assignee | ||
Comment 3•20 years ago
|
||
Attachment #152677 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #153570 -
Flags: review?
Comment 4•20 years ago
|
||
Comment on attachment 153570 [details] [diff] [review]
Fixed patch
r=jouni
Attachment #153570 -
Flags: review? → review+
Updated•20 years ago
|
Flags: approval?
Updated•20 years ago
|
Flags: approval? → approval+
Comment 5•20 years ago
|
||
Thanks for the patch!
Checking in Bugzilla/FlagType.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/FlagType.pm,v <-- FlagType.pm
new revision: 1.8; previous revision: 1.7
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•