Closed
Bug 2529
Opened 26 years ago
Closed 26 years ago
nsViewManager only defines a private destructor
Categories
(Core Graveyard :: GFX, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: akkzilla, Assigned: michaelp)
Details
Building nsViewManager.cpp on Linux gives the warning:
../../../mozilla/view/src/nsViewManager.h:148: warning: `class nsViewManager'
only defines a private destructor and has no friends
it uses Release() to call delete this, so the destructor does not need to be
public. i think the warning is bogus in this case.
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 4•26 years ago
|
||
Yikes! Yes, that warning is gone, but now there are a bunch of new warnings in
that file:
nsViewManager.cpp: In method `unsigned int nsViewManager::UpdateView(class
nsIView *, const struct nsRect &, unsigned int)':
nsViewManager.cpp:743: warning: unsigned int format, pointer arg (arg 2)
nsViewManager.cpp: In method `void nsViewManager::AddRectToDirtyRegion(class
nsIView *, const struct nsRect &) const':
nsViewManager.cpp:1545: warning: unused variable `unsigned int rv'
nsViewManager.cpp: In method `unsigned int nsViewManager::Display(class nsIView
*)':
nsViewManager.cpp:1618: warning: unused variable `void * ds'
nsViewManager.cpp:1616: warning: unused variable `struct nsRect wrect'
I'll go ahead and mark the bug resolved since none of these warnings are really
that important (the only one that looks bad is the first one, and that's in a
printf so who cares?)
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•