Closed
Bug 256833
Opened 20 years ago
Closed 20 years ago
Right arrow skips some text after <HR>
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
(Keywords: access, Whiteboard: sunport17)
Attachments
(2 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
aaronlev
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
Use right arrow go through the doc,
some text are skiped after <HR>.
Try the testcase attached
Test case 1,
one line is skiped, caret goes to ^Line4.
Test case 2,
one line and a character are skiped, caret goes to L^ine4.
We do not need go to next line in this way.
result = framTraversal->Next(); will bring us there.
If we advance the linenum and do Next(), we miss one frame.
In fact, caret will not stop at <BR>, but it stops at end of <HR>.
So we have this bug.
Assignee: aaronleventhal → ginn.chen
Status: NEW → ASSIGNED
Attachment #157042 -
Flags: review?(aaronleventhal)
|
||
Comment 3•20 years ago
|
||
Comment on attachment 157042 [details] [diff] [review]
patch
Code removal -- great.
Now what's wrong with using left arrow over an <HR>? The caret seems to get
lost.
Attachment #157042 -
Flags: review?(aaronleventhal) → review+
(In reply to comment #3)
> (From update of attachment 157042 [details] [diff] [review])
> Code removal -- great.
>
> Now what's wrong with using left arrow over an <HR>? The caret seems to get
> lost.
>
Maybe caret gets into the bar, press left arrow again, it will get out.
I'll look into it when I've time, too many keyboard navigation bugs now.
Attachment #157042 -
Flags: superreview?(dbaron)
Attachment #157042 -
Flags: superreview?(dbaron) → superreview?(jst)
|
||
Comment 5•20 years ago
|
||
Comment on attachment 157042 [details] [diff] [review]
patch
Dbaron knows more about this code than I do, requesting sr from him...
Attachment #157042 -
Flags: superreview?(jst) → superreview?(dbaron)
|
|
||
Updated•20 years ago
|
Whiteboard: sunport17
|
||
Comment 6•20 years ago
|
||
Comment on attachment 157042 [details] [diff] [review]
patch
I really don't have a clue about this code, but code removal seems nice if it
fixes things and doesn't break others, so sr=dbaron.
Attachment #157042 -
Flags: superreview?(dbaron) → superreview+
Checking in html/base/src/nsFrame.cpp;
/cvsroot/mozilla/layout/html/base/src/nsFrame.cpp,v <-- nsFrame.cpp
new revision: 3.528; previous revision: 3.527
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: Keyboard: Navigation → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•